git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: git@vger.kernel.org
Cc: Jiri Kosina <jkosina@suse.cz>
Subject: more problems with commit encoding [Was: [PATCH] shortlog: respect commit encoding]
Date: Tue, 24 Nov 2009 17:08:37 +0100	[thread overview]
Message-ID: <20091124160837.GA7296@pengutronix.de> (raw)
In-Reply-To: <1259075555-7831-1-git-send-email-u.kleine-koenig@pengutronix.de>

Hello,

On Tue, Nov 24, 2009 at 04:12:35PM +0100, Uwe Kleine-König wrote:
> Before this change the author was taken from the raw commit without
> reencoding.
while at it, userformats have the same problem:

	linux-2.6$ for rev in b71a8eb bc9be01; do git show --format=%an $rev | head -n1; git show $rev | grep Auth; done
	Uwe Kleine-K�nig
	Author: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
	Uwe Kleine-König
	Author: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

That is, git show correctly reencodes its output for b71a8eb, but only
without --format=...

(The patches above are in linux-next.)

And now take this (assuming locale and commitencoding are utf-8):

	git init
	git config user.name 'Jöhännës Dschö'
	echo spam > ham
	git add ham
	git commit -m 'initial commit'
	git branch branch
	echo more spam > ham
	git add ham
	git commit -m "Commitlog matching '\nencoding:'

encoding: latin1
"
	git checkout branch
	echo much more spam > ham
	git add ham
	git commit -C master
	git show | grep Author:

Best regards
Uwe

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |

  reply	other threads:[~2009-11-24 16:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1256757064-13669-1-git-send-email-u.kleine-koenig@pengutronix.de>
     [not found] ` <alpine.LSU.2.00.0911021600530.4203@wotan.suse.de>
     [not found]   ` <20091103081447.GA20204@pengutronix.de>
     [not found]     ` <alpine.LSU.2.00.0911031144300.9988@wotan.suse.de>
     [not found]       ` <20091111114206.GA19652@pengutronix.de>
     [not found]         ` <alpine.LSU.2.00.0911111318260.15039@wotan.suse.de>
2009-11-11 14:13           ` commit log encoding [Was: [PATCH 1/2] tree-wide: fix typos "offest" -> "offset"] Uwe Kleine-König
2009-11-24 15:12             ` [PATCH] shortlog: respect commit encoding Uwe Kleine-König
2009-11-24 16:08               ` Uwe Kleine-König [this message]
2009-11-25  1:12               ` Junio C Hamano
2009-11-25 14:00                 ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091124160837.GA7296@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=git@vger.kernel.org \
    --cc=jkosina@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).