From: Jonathan Nieder <jrnieder@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: What's cooking in git.git (Nov 2009, #06; Wed, 25)
Date: Fri, 27 Nov 2009 08:45:53 -0600 [thread overview]
Message-ID: <20091127144553.GA24366@progeny.tock> (raw)
In-Reply-To: <20091127065904.GE20844@coredump.intra.peff.net>
Jeff King wrote:
> On Wed, Nov 25, 2009 at 05:03:33PM -0800, Junio C Hamano wrote:
>> * jc/grep-full-tree (2009-11-24) 1 commit.
>> - grep: --full-tree
>>
>> We probably would want test, doc and a configuration variable to make it
>> default (or non-default) before we can merge it to 'master'.
>
> I can try to pick this up. But did we reach a decision on having a
> configuration variable?
I am not sure, but I will say I would prefer not to have one. Surely
we can come up with a UI that does not require searching through
git-config(1) to be made convenient.
Couldn’t we just add the option (with test and documentation) first,
to get some experience with how we end up using the two forms?
If --full-tree does become the default, I think it should be in 1.7.0,
when it is expected for some habits to break (with a configuration
variable for the transition, I guess). This might be okay, since
constructions like 'git grep foo -- "./*.h"' should still work.
next prev parent reply other threads:[~2009-11-27 14:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-26 1:03 What's cooking in git.git (Nov 2009, #06; Wed, 25) Junio C Hamano
2009-11-26 1:15 ` Sverre Rabbelier
2009-11-26 7:37 ` Johan Herland
2009-11-27 19:17 ` Daniel Barkalow
2009-11-28 0:45 ` Sverre Rabbelier
2009-11-27 6:59 ` Jeff King
2009-11-27 14:45 ` Jonathan Nieder [this message]
2009-11-27 14:38 ` Breaking expectations in 1.7.0, was " Johannes Schindelin
2009-11-27 15:33 ` Jonathan Nieder
2009-11-27 18:32 ` Jonathan Nieder
2009-11-27 18:29 ` Junio C Hamano
2009-11-27 18:58 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091127144553.GA24366@progeny.tock \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).