From: Matthew Ogilvie <mmogilvi_git@miniinfo.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH 3/4] build dashless "test-bin" directory similar to installed bindir
Date: Sat, 28 Nov 2009 21:23:55 -0700 [thread overview]
Message-ID: <20091129042355.GA2252@comcast.net> (raw)
In-Reply-To: <7vaay6f4ce.fsf@alter.siamese.dyndns.org>
On Sat, Nov 28, 2009 at 06:32:33PM -0800, Junio C Hamano wrote:
> Why can't t/Makefile have a dependency on its 'default' target that goes
> up and prepares test-bin/, i.e. "cd .. && make test-bin-stuff"?
That wouldn't help with someone manually running specific tests,
which is a common way to run tests when working on git:
hackhackhack && make && cd t && ./tXXXX-*.sh
Perhaps we could invoke make from test-lib.sh, but at that point
it starts to look more attractive to just do it the same way as the
valgrind option, even though that means duplicating the appropriate
list of executables in test-lib.sh.
Also, "make all" already builds some test suite support
binaries (test-*). Is it really worth any effort to leave
a few short wrapper scripts out of "make all" when it is already
building several test binaries?
(See also my much longer email response that crossed this one in the
mail.)
--
Matthew Ogilvie [mmogilvi_git@miniinfo.net]
next prev parent reply other threads:[~2009-11-29 4:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-28 18:38 [PATCH 0/4] Run test suite without dashed commands in PATH Matthew Ogilvie
2009-11-28 18:38 ` [PATCH 1/4] t2300: use documented technique to invoke git-sh-setup Matthew Ogilvie
2009-11-28 18:38 ` [PATCH 2/4] t3409 t4107 t7406: use dashless commands Matthew Ogilvie
2009-11-28 18:38 ` [PATCH 3/4] build dashless "test-bin" directory similar to installed bindir Matthew Ogilvie
2009-11-28 18:38 ` [PATCH 4/4] run test suite without dashed git-commands in PATH Matthew Ogilvie
2009-11-28 19:44 ` [PATCH 3/4] build dashless "test-bin" directory similar to installed bindir Junio C Hamano
2009-11-28 19:49 ` Jeff King
2009-11-29 2:32 ` Junio C Hamano
2009-11-29 3:43 ` Jeff King
2009-11-29 5:07 ` Junio C Hamano
2009-11-29 5:10 ` Jeff King
2009-11-29 4:23 ` Matthew Ogilvie [this message]
2009-11-29 2:52 ` Matthew Ogilvie
2009-11-30 7:07 ` Nanako Shiraishi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091129042355.GA2252@comcast.net \
--to=mmogilvi_git@miniinfo.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).