From: Tay Ray Chuan <rctay89@gmail.com>
To: git@vger.kernel.org
Cc: Daniel Barkalow <barkalow@iabervon.org>,
Sverre Rabbelier <srabbelier@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>
Subject: [PATCH] transport-helper: remove duplicate free()
Date: Wed, 2 Dec 2009 15:39:50 +0800 [thread overview]
Message-ID: <20091202153950.c18095b7.rctay89@gmail.com> (raw)
Remove the free() invocation on transport->data in release_helper(), as
disconnect_helper() has already done so.
Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
---
Applies on top of 'next'.
transport-helper.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/transport-helper.c b/transport-helper.c
index 9c5f860..2f77bd5 100644
--- a/transport-helper.c
+++ b/transport-helper.c
@@ -196,7 +196,6 @@ static int release_helper(struct transport *transport)
free_refspec(data->refspec_nr, data->refspecs);
data->refspecs = NULL;
disconnect_helper(transport);
- free(transport->data);
return 0;
}
--
1.6.6.rc0.306.g5bb1c0
next reply other threads:[~2009-12-02 7:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-02 7:39 Tay Ray Chuan [this message]
2009-12-02 16:23 ` [PATCH] transport-helper: remove duplicate free() Daniel Barkalow
2009-12-02 19:06 ` Junio C Hamano
2009-12-02 23:00 ` Tay Ray Chuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091202153950.c18095b7.rctay89@gmail.com \
--to=rctay89@gmail.com \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).