From: "Shawn O. Pearce" <spearce@spearce.org>
To: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
Cc: git@vger.kernel.org
Subject: Re: [RFC PATCH 4/8] Support remote helpers implementing smart transports
Date: Wed, 2 Dec 2009 09:04:57 -0800 [thread overview]
Message-ID: <20091202170457.GC31648@spearce.org> (raw)
In-Reply-To: <20091202055543.GC31244@Knoppix>
Ilari Liusvaara <ilari.liusvaara@elisanet.fi> wrote:
> On Tue, Dec 01, 2009 at 11:22:33AM -0800, Shawn O. Pearce wrote:
> > Why both connect-r and invoke-r? Why isn't connect-r sufficient
> > here? Isn't it sufficient for any service that runs over git:// ?
>
> Invoke supports those --upload-pack &co (a'la ssh://). connect
> doesn't (a'la to git://).
Drop invoke-r.
Modify transport-helper.c to allow pushing TRANS_OPT_UPLOADPACK and
TRANS_OPT_RECEIVEPACK down into the helper via the option capability.
I'd rename connect-r to just connect.
For the command line:
$ git fetch --upload-pack='/path to my /git-upload-pack' origin
The conversation with the helper will be:
> capabilities
< option
< connect
<
> option uploadpack /path to my /git-upload-pack
< ok
> connect git-upload-pack
<
Which gives the helper the full information it needs to pass along
the --upload-pack command line argument to the remote system.
--
Shawn.
next prev parent reply other threads:[~2009-12-02 17:05 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-01 13:57 [RFC PATCH 0/8] Git remote helpers to implement smart transports Ilari Liusvaara
2009-12-01 13:57 ` [RFC PATCH 1/8] Pass unknown protocols to external protocol handlers Ilari Liusvaara
2009-12-01 13:57 ` [RFC PATCH 2/8] Refactor git transport options parsing Ilari Liusvaara
2009-12-01 13:57 ` [RFC PATCH 3/8] Support taking over transports Ilari Liusvaara
2009-12-01 13:57 ` [RFC PATCH 4/8] Support remote helpers implementing smart transports Ilari Liusvaara
2009-12-01 19:22 ` Shawn O. Pearce
2009-12-02 5:55 ` Ilari Liusvaara
2009-12-02 17:04 ` Shawn O. Pearce [this message]
2009-12-02 20:10 ` Ilari Liusvaara
2009-12-03 19:42 ` Shawn O. Pearce
2009-12-02 17:12 ` Shawn O. Pearce
2009-12-01 13:57 ` [RFC PATCH 5/8] Support remote archive from external protocol helpers Ilari Liusvaara
2009-12-01 13:57 ` [RFC PATCH 6/8] Remove special casing of http, https and ftp Ilari Liusvaara
2009-12-01 18:24 ` Shawn O. Pearce
2009-12-01 19:39 ` Ilari Liusvaara
2009-12-01 19:15 ` Daniel Barkalow
2009-12-02 5:52 ` Ilari Liusvaara
2009-12-01 13:57 ` [RFC PATCH 7/8] Add remote helper debug mode Ilari Liusvaara
2009-12-01 13:57 ` [RFC PATCH 8/8] Support mandatory capabilities Ilari Liusvaara
2009-12-01 16:12 ` [RFC PATCH 0/8] Git remote helpers to implement smart transports Sverre Rabbelier
2009-12-01 16:52 ` Shawn O. Pearce
2009-12-01 17:19 ` Ilari Liusvaara
2009-12-01 19:30 ` Shawn O. Pearce
2009-12-01 20:42 ` Junio C Hamano
2009-12-01 23:20 ` Shawn O. Pearce
2009-12-02 5:56 ` Ilari Liusvaara
2009-12-02 6:35 ` Junio C Hamano
2009-12-02 16:04 ` Ilari Liusvaara
2009-12-02 17:26 ` Junio C Hamano
2009-12-02 17:39 ` Johannes Schindelin
2009-12-02 18:06 ` Sverre Rabbelier
2009-12-02 18:41 ` Junio C Hamano
2009-12-02 18:50 ` Sverre Rabbelier
2009-12-02 18:52 ` Junio C Hamano
2009-12-02 18:55 ` Sverre Rabbelier
2009-12-02 18:58 ` Junio C Hamano
2009-12-02 19:39 ` Jeff King
2009-12-02 19:25 ` Ilari Liusvaara
2009-12-02 18:07 ` Junio C Hamano
2009-12-02 18:47 ` Ilari Liusvaara
2009-12-02 19:52 ` Ilari Liusvaara
2009-12-02 5:50 ` Ilari Liusvaara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091202170457.GC31648@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=ilari.liusvaara@elisanet.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).