From: Jeff King <peff@peff.net>
To: Miklos Vajna <vmiklos@frugalware.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] builtin-commit: add --date option
Date: Wed, 2 Dec 2009 14:26:14 -0500 [thread overview]
Message-ID: <20091202192614.GD30778@coredump.intra.peff.net> (raw)
In-Reply-To: <1259627252-21615-1-git-send-email-vmiklos@frugalware.org>
On Tue, Dec 01, 2009 at 01:27:32AM +0100, Miklos Vajna wrote:
> This is useful in case git commit --amend is used but the user wants to
> set the date of the new commit to a specified one, since GIT_AUTHOR_DATE
> is ignored in such a situation.
Do you really want to set the date to something arbitrary, or do you
just want to set it to "now"? If the latter case, do you really just
want the recently discussed --reset-author?
Also, is there a good reason why GIT_AUTHOR_DATE is not respected in
this case? If not, should we simply be fixing that bug instead?
-Peff
next prev parent reply other threads:[~2009-12-02 19:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-01 0:27 [PATCH] builtin-commit: add --date option Miklos Vajna
2009-12-02 17:11 ` Miklos Vajna
2009-12-02 17:35 ` Junio C Hamano
2009-12-02 17:55 ` Junio C Hamano
2009-12-02 21:40 ` Miklos Vajna
2009-12-02 19:24 ` Jeff King
2009-12-02 20:33 ` Miklos Vajna
2009-12-02 19:26 ` Jeff King [this message]
2009-12-02 19:38 ` Junio C Hamano
2009-12-02 21:07 ` Miklos Vajna
2009-12-02 22:16 ` [PATCH 1/2] " Miklos Vajna
2009-12-02 22:16 ` [PATCH 2/2] Document date formats accepted by parse_date() Miklos Vajna
2009-12-02 22:33 ` Nanako Shiraishi
2009-12-02 22:42 ` Jeff King
2009-12-02 22:54 ` Junio C Hamano
2009-12-02 23:49 ` [PATCH 2/2 v2] " Miklos Vajna
2009-12-02 22:12 ` [PATCH] builtin-commit: add --date option Miklos Vajna
2009-12-02 22:22 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091202192614.GD30778@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).