From: Johannes Sixt <j6t@kdbg.org>
To: kusmabite@gmail.com
Cc: msysgit@googlegroups.com, git@vger.kernel.org, dotzenlabs@gmail.com
Subject: Re: [msysGit] [PATCH/RFC 09/11] daemon: use run-command api for async serving
Date: Wed, 2 Dec 2009 20:12:08 +0100 [thread overview]
Message-ID: <200912022012.08905.j6t@kdbg.org> (raw)
In-Reply-To: <40aa078e0912020745o4b72342fm722a944621cfda5@mail.gmail.com>
On Mittwoch, 2. Dezember 2009, Erik Faye-Lund wrote:
> On Fri, Nov 27, 2009 at 9:59 PM, Johannes Sixt <j6t@kdbg.org> wrote:
> > Would it make sense to
> > have a function finish_async_nowait() instead of is_async_alive() that
> > (1) stresses the start/finish symmetry and (2) can return more than just
> > Boolean?
>...
>
> I'm not entirely sure how to make the interface, though. Any good
> suggestions?
I suggest to model finish_async_nowait() after waitpid() so that
while ((pid = waitpid(-1, &status, WNOHANG)) > 0) ...
becomes
while ((pid = finish_async_nowait(&some_async, &status)) > 0) ...
but where the resulting status is already "decoded", i.e. zero is success and
non-zero is failure (including death through signal); WIFEXITED and
WEXITSTATUS should not be applicable to status anymore.
-- Hannes
next prev parent reply other threads:[~2009-12-02 19:12 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-26 0:44 [PATCH/RFC 00/11] daemon-win32 Erik Faye-Lund
2009-11-26 0:44 ` [PATCH/RFC 01/11] mingw: add network-wrappers for daemon Erik Faye-Lund
2009-11-26 0:44 ` [PATCH/RFC 02/11] strbuf: add non-variadic function strbuf_vaddf() Erik Faye-Lund
2009-11-26 0:44 ` [PATCH/RFC 03/11] mingw: implement syslog Erik Faye-Lund
2009-11-26 0:44 ` [PATCH/RFC 04/11] compat: add inet_pton and inet_ntop prototypes Erik Faye-Lund
2009-11-26 0:44 ` [PATCH/RFC 05/11] inet_ntop: fix a couple of old-style decls Erik Faye-Lund
2009-11-26 0:44 ` [PATCH/RFC 06/11] run-command: add kill_async() and is_async_alive() Erik Faye-Lund
2009-11-26 0:44 ` [PATCH/RFC 07/11] run-command: support input-fd Erik Faye-Lund
2009-11-26 0:44 ` [PATCH/RFC 08/11] daemon: use explicit file descriptor Erik Faye-Lund
2009-11-26 0:44 ` [PATCH/RFC 09/11] daemon: use run-command api for async serving Erik Faye-Lund
2009-11-26 0:44 ` [PATCH/RFC 10/11] daemon: use full buffered mode for stderr Erik Faye-Lund
2009-11-26 0:44 ` [PATCH/RFC 11/11] mingw: compile git-daemon Erik Faye-Lund
2009-11-27 21:17 ` [msysGit] " Johannes Sixt
2009-11-27 20:59 ` [msysGit] [PATCH/RFC 09/11] daemon: use run-command api for async serving Johannes Sixt
2009-12-02 15:45 ` Erik Faye-Lund
2009-12-02 19:12 ` Johannes Sixt [this message]
2009-12-08 13:36 ` Erik Faye-Lund
2009-11-26 22:03 ` [msysGit] [PATCH/RFC 08/11] daemon: use explicit file descriptor Johannes Sixt
2009-11-27 14:23 ` Erik Faye-Lund
2009-11-27 15:46 ` Erik Faye-Lund
2009-11-27 20:23 ` Johannes Sixt
2009-11-27 20:28 ` Johannes Sixt
2009-12-08 13:38 ` Erik Faye-Lund
2009-11-26 21:53 ` [msysGit] [PATCH/RFC 07/11] run-command: support input-fd Johannes Sixt
2009-11-27 14:39 ` Erik Faye-Lund
2009-11-27 20:14 ` Johannes Sixt
2009-12-08 13:46 ` Erik Faye-Lund
2009-11-26 21:46 ` [msysGit] [PATCH/RFC 06/11] run-command: add kill_async() and is_async_alive() Johannes Sixt
2009-11-27 16:04 ` Erik Faye-Lund
2009-11-27 19:59 ` Johannes Sixt
2009-12-02 15:57 ` Erik Faye-Lund
2009-12-02 19:27 ` Johannes Sixt
2010-01-09 0:49 ` Erik Faye-Lund
2010-01-10 17:06 ` Erik Faye-Lund
2009-11-26 21:23 ` [msysGit] [PATCH/RFC 03/11] mingw: implement syslog Johannes Sixt
2009-11-27 8:09 ` Erik Faye-Lund
2009-11-27 19:23 ` Johannes Sixt
2009-12-08 14:01 ` Erik Faye-Lund
2009-11-26 0:59 ` [PATCH/RFC 02/11] strbuf: add non-variadic function strbuf_vaddf() Junio C Hamano
2009-11-26 10:38 ` Erik Faye-Lund
2009-11-26 11:13 ` Paolo Bonzini
2009-11-26 18:46 ` Junio C Hamano
2009-11-26 23:37 ` Erik Faye-Lund
2009-11-27 7:09 ` Johannes Sixt
2009-11-26 8:24 ` [PATCH/RFC 01/11] mingw: add network-wrappers for daemon Martin Storsjö
2009-11-26 10:43 ` [PATCH] Improve the mingw getaddrinfo stub to handle more use cases Martin Storsjö
2009-11-26 10:46 ` [PATCH/RFC 01/11] mingw: add network-wrappers for daemon Erik Faye-Lund
2009-11-26 11:03 ` Martin Storsjö
2009-12-02 13:01 ` Erik Faye-Lund
2009-12-02 13:21 ` Martin Storsjö
2009-12-02 13:49 ` Erik Faye-Lund
2009-12-02 15:11 ` Erik Faye-Lund
2009-12-02 19:34 ` Johannes Sixt
2009-11-26 20:04 ` [msysGit] [PATCH/RFC 00/11] daemon-win32 Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912022012.08905.j6t@kdbg.org \
--to=j6t@kdbg.org \
--cc=dotzenlabs@gmail.com \
--cc=git@vger.kernel.org \
--cc=kusmabite@gmail.com \
--cc=msysgit@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).