git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Miklos Vajna <vmiklos@frugalware.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] builtin-commit: add --date option
Date: Wed, 2 Dec 2009 17:22:57 -0500	[thread overview]
Message-ID: <20091202222257.GA9691@coredump.intra.peff.net> (raw)
In-Reply-To: <20091202221232.GF31763@genesis.frugalware.org>

On Wed, Dec 02, 2009 at 11:12:32PM +0100, Miklos Vajna wrote:

> No, I want to set it to two days ago, for example when I forgot to
> commit at the end of the day and I notice it two days later before I
> start to work on something again.

OK. I think you are being overly meticulous about your commit date, but
that is your right. ;)

> > Also, is there a good reason why GIT_AUTHOR_DATE is not respected in
> > this case?  If not, should we simply be fixing that bug instead?
> 
> GIT_AUTHOR_DATE is respected by --reset-author, just given that we have
> --author already, using environment variables for a user can be
> uncomfortable.

OK, I can agree with that reasoning.

-Peff

      reply	other threads:[~2009-12-02 22:23 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-01  0:27 [PATCH] builtin-commit: add --date option Miklos Vajna
2009-12-02 17:11 ` Miklos Vajna
2009-12-02 17:35   ` Junio C Hamano
2009-12-02 17:55     ` Junio C Hamano
2009-12-02 21:40       ` Miklos Vajna
2009-12-02 19:24     ` Jeff King
2009-12-02 20:33       ` Miklos Vajna
2009-12-02 19:26 ` Jeff King
2009-12-02 19:38   ` Junio C Hamano
2009-12-02 21:07     ` Miklos Vajna
2009-12-02 22:16     ` [PATCH 1/2] " Miklos Vajna
2009-12-02 22:16       ` [PATCH 2/2] Document date formats accepted by parse_date() Miklos Vajna
2009-12-02 22:33         ` Nanako Shiraishi
2009-12-02 22:42           ` Jeff King
2009-12-02 22:54           ` Junio C Hamano
2009-12-02 23:49             ` [PATCH 2/2 v2] " Miklos Vajna
2009-12-02 22:12   ` [PATCH] builtin-commit: add --date option Miklos Vajna
2009-12-02 22:22     ` Jeff King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091202222257.GA9691@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=vmiklos@frugalware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).