From: Johan Herland <johan@herland.net>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [RFC/PATCHv9 01/11] fast-import: Proper notes tree manipulation
Date: Wed, 02 Dec 2009 23:41:55 +0100 [thread overview]
Message-ID: <200912022341.55474.johan@herland.net> (raw)
In-Reply-To: <20091202203953.GE31648@spearce.org>
On Wednesday 02 December 2009, Shawn O. Pearce wrote:
> Johan Herland <johan@herland.net> wrote:
> > diff --git a/fast-import.c b/fast-import.c
> > index b41d29f..b51ffbc 100644
> > --- a/fast-import.c
> > +++ b/fast-import.c
>
> This new version is much cleaner, thank you.
Thank you for the suggestions that made it so :)
The rest of your comments all make perfect sense. I'll whip up a replacement
patch shortly.
Thanks for the review!
...Johan
--
Johan Herland, <johan@herland.net>
www.herland.net
next prev parent reply other threads:[~2009-12-02 22:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-02 2:09 [RFC/PATCHv9 00/11] git notes Johan Herland
2009-12-02 2:09 ` [RFC/PATCHv9 01/11] fast-import: Proper notes tree manipulation Johan Herland
2009-12-02 20:39 ` Shawn O. Pearce
2009-12-02 22:41 ` Johan Herland [this message]
2009-12-03 3:45 ` Johan Herland
2009-12-02 2:09 ` [RFC/PATCHv9 02/11] Rename t9301 to t9350, to make room for more fast-import tests Johan Herland
2009-12-02 2:09 ` [RFC/PATCHv9 03/11] Add more testcases to test fast-import of notes Johan Herland
2009-12-02 2:09 ` [RFC/PATCHv9 04/11] Minor style fixes to notes.c Johan Herland
2009-12-02 2:09 ` [RFC/PATCHv9 05/11] Notes API: get_commit_notes() -> format_note() + remove the commit restriction Johan Herland
2009-12-02 2:09 ` [RFC/PATCHv9 06/11] Notes API: init_notes(): Initialize the notes tree from the given notes ref Johan Herland
2009-12-02 2:09 ` [RFC/PATCHv9 07/11] Notes API: add_note(): Add note objects to the internal notes tree structure Johan Herland
2009-12-02 2:09 ` [RFC/PATCHv9 08/11] Notes API: get_note(): Return the note annotating the given object Johan Herland
2009-12-02 2:09 ` [RFC/PATCHv9 09/11] Notes API: for_each_note(): Traverse the entire notes tree with a callback Johan Herland
2009-12-02 2:09 ` [RFC/PATCHv9 10/11] Notes API: Allow multiple concurrent notes trees with new struct notes_tree Johan Herland
2009-12-02 2:09 ` [RFC/PATCHv9 11/11] Refactor notes concatenation into a flexible interface for combining notes Johan Herland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912022341.55474.johan@herland.net \
--to=johan@herland.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).