From: Jindrich Makovicka <makovick@gmail.com>
To: git@vger.kernel.org
Subject: [PATCH] git-gui: suppress the X error on exit
Date: Fri, 4 Dec 2009 10:28:44 +0100 [thread overview]
Message-ID: <20091204102844.3c720b21@starbug.prg01.itonis.net> (raw)
Hi,
Due to a bug in Tk, git-gui almost always (unless git-gui is closed
right after starting) produces an X window error message on exit,
something like
X Error of failed request: RenderBadPicture (invalid Picture parameter)
Major opcode of failed request: 150 (RENDER)
Minor opcode of failed request: 7 (RenderFreePicture)
Picture id in failed request: 0x3a000dc
Serial number of failed request: 1965
Current serial number in output stream: 1980
Respective Tk bug report is here:
http://sourceforge.net/tracker/?func=detail&atid=112997&aid=1821174&group_id=12997
This bug is triggered only when the send command is blocked via
rename send {} . The following patch re-enables send just
before quiting git-gui to suppress the error.
--- git-gui~ 2009-11-17 23:28:30.000000000 +0100
+++ git-gui 2009-12-03 23:32:50.848588924 +0100
@@ -2023,6 +2023,10 @@
}
set ret_code $rc
+
+ # briefly re-enable send to suppress the RenderBadPicture error
+ tk appname [appname]
+
destroy .
}
next reply other threads:[~2009-12-04 9:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-04 9:28 Jindrich Makovicka [this message]
2009-12-04 15:57 ` [PATCH] git-gui: suppress the X error on exit Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091204102844.3c720b21@starbug.prg01.itonis.net \
--to=makovick@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox