From: Jeff King <peff@peff.net>
To: "James P. Howard, II" <jh@jameshoward.us>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Cast &cp to eliminate a compile-time warning on FreeBSD 8-STABLE.
Date: Sat, 5 Dec 2009 11:14:05 -0500 [thread overview]
Message-ID: <20091205161405.GA9272@sigill.intra.peff.net> (raw)
In-Reply-To: <1259968322-66072-1-git-send-email-jh@jameshoward.us>
On Fri, Dec 04, 2009 at 06:12:02PM -0500, James P. Howard, II wrote:
> --- a/utf8.c
> +++ b/utf8.c
> @@ -449,7 +449,7 @@ char *reencode_string(const char *in, const char *out_encoding, const char *in_e
> cp = (iconv_ibp)in;
>
> while (1) {
> - size_t cnt = iconv(conv, &cp, &insz, &outpos, &outsz);
> + size_t cnt = iconv(conv, (const char **)&cp, &insz, &outpos, &outsz);
>
> if (cnt == -1) {
> size_t sofar;
Aren't you now introducing a warning for all of the other platforms
which take a "char **"? Should you instead just be building with
OLD_ICONV=Yes on your platform? See commit fd547a9 for details.
-Peff
next prev parent reply other threads:[~2009-12-05 16:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-04 23:12 [PATCH] Cast &cp to eliminate a compile-time warning on FreeBSD 8-STABLE James P. Howard, II
2009-12-05 16:14 ` Jeff King [this message]
2009-12-05 23:03 ` James P. Howard, II
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091205161405.GA9272@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=jh@jameshoward.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox