From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff King Subject: Re: [PATCH] Add commit.infodisplay option to give message editor empty file Date: Sat, 5 Dec 2009 23:22:06 -0500 Message-ID: <20091206042206.GC23983@coredump.intra.peff.net> References: <1259967879-65517-1-git-send-email-jh@jameshoward.us> <7vpr6t6fnz.fsf@alter.siamese.dyndns.org> <20091205154753.GA3717@thermopylae.local> <20091205162827.GA9584@sigill.intra.peff.net> <20091205230903.GA3816@thermopylae.local> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: git@vger.kernel.org To: "James P. Howard, II" X-From: git-owner@vger.kernel.org Sun Dec 06 05:22:16 2009 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1NH8dS-0007k2-Vg for gcvg-git-2@lo.gmane.org; Sun, 06 Dec 2009 05:22:15 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758109AbZLFEWE (ORCPT ); Sat, 5 Dec 2009 23:22:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758106AbZLFEWD (ORCPT ); Sat, 5 Dec 2009 23:22:03 -0500 Received: from peff.net ([208.65.91.99]:48220 "EHLO peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758105AbZLFEWC (ORCPT ); Sat, 5 Dec 2009 23:22:02 -0500 Received: (qmail 28458 invoked by uid 107); 6 Dec 2009 04:26:38 -0000 Received: from coredump.intra.peff.net (HELO coredump.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.40) with (AES128-SHA encrypted) SMTP; Sat, 05 Dec 2009 23:26:38 -0500 Received: by coredump.intra.peff.net (sSMTP sendmail emulation); Sat, 05 Dec 2009 23:22:06 -0500 Content-Disposition: inline In-Reply-To: <20091205230903.GA3816@thermopylae.local> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Sat, Dec 05, 2009 at 06:09:03PM -0500, James P. Howard, II wrote: > On Sat, Dec 05, 2009 at 11:28:27AM -0500, Jeff King wrote: > > > If the latter, I think we would be better served by an option to simply > > turn off the template. Then that is also helpful for the case of people > > using decent editors, but who don't want to waste the CPU time on > > generating the template information (which can be substantial for things > > like media repositories). > > Actually, I find this a reasonable solution for both cases and would be > willing to reimplment my change this way, as it meets my needs and would > be useful to others. The only question I have is, what should variable/ > command line option be called? I would be tempted to call it "--no-template", but I think that is too confusing. The "--template" option is not really about the git-generated template, but about a user-defined template that goes on top of the git-generated one (I would have expected --template=/dev/null to do what you want, too, but it retains the git template). Probably "--no-status" would be a good name, as the generated template is the format generated by "git status". -Peff