git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "James P. Howard, II" <jh@jameshoward.us>, git@vger.kernel.org
Subject: Re: [PATCH] Add commit.infodisplay option to give message editor empty file
Date: Sun, 6 Dec 2009 08:12:18 -0500	[thread overview]
Message-ID: <20091206131217.GA12851@sigill.intra.peff.net> (raw)
In-Reply-To: <7v7ht0jzta.fsf@alter.siamese.dyndns.org>

On Sun, Dec 06, 2009 at 12:01:53AM -0800, Junio C Hamano wrote:

> Jeff King <peff@peff.net> writes:
> 
> > I would be tempted to call it "--no-template", but I think that is too
> > confusing. The "--template" option is not really about the git-generated
> > template, but about a user-defined template that goes on top of the
> > git-generated one (I would have expected --template=/dev/null to do what
> > you want, too, but it retains the git template).
> >
> > Probably "--no-status" would be a good name, as the generated template
> > is the format generated by "git status".
> 
> I wonder which part is the most expensive in generating the status
> output.  Perhaps -suno is sufficient?

Speaking from my experience, it is doing break and rename detection on
large files, which there is currently no way to turn off (I hacked
around it with "$EDITOR msg && git commit --quiet -F msg").

Keep in mind this is one of my gigantic photo repositories, and the
commit in question made a minor change to almost 3G worth of files. So
it is not the end of the world for me to use the hack above on those
rare occasions. But since James wants it for other reasons, and it
should be a trivial patch, I think it would be nice for commit to
support it natively.

It would also make sense to me for "--quiet" to suppress the template,
but that is a behavior change that I suppose some people might not like.

-Peff

  reply	other threads:[~2009-12-06 13:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-04 23:04 [PATCH] Add commit.infodisplay option to give message editor empty file James P. Howard, II
2009-12-05  7:30 ` Junio C Hamano
2009-12-05 15:47   ` James P. Howard, II
2009-12-05 16:28     ` Jeff King
2009-12-05 23:09       ` James P. Howard, II
2009-12-06  4:22         ` Jeff King
2009-12-06  8:01           ` Junio C Hamano
2009-12-06 13:12             ` Jeff King [this message]
2009-12-07 22:45               ` [PATCH] Add commit.status, --status, and --no-status James P. Howard, II
2009-12-08  0:39                 ` James Pickens
2009-12-08  6:04                 ` Jeff King
2009-12-08  7:13                   ` Junio C Hamano
2009-12-08  7:55                     ` Jeff King
2009-12-08 14:07                     ` James P. Howard, II
2009-12-07 22:43           ` [PATCH] Add commit.infodisplay option to give message editor empty file James P. Howard, II

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091206131217.GA12851@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jh@jameshoward.us \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).