From: Jeff King <peff@peff.net>
To: Alex Vandiver <alex@chmrr.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Allow --quiet option to git remote, particularly for `git remote update`
Date: Sun, 6 Dec 2009 09:50:00 -0500 [thread overview]
Message-ID: <20091206145000.GC26440@coredump.intra.peff.net> (raw)
In-Reply-To: <1260057623-28960-1-git-send-email-alex@chmrr.net>
On Sat, Dec 05, 2009 at 07:00:23PM -0500, Alex Vandiver wrote:
> @@ -84,9 +84,12 @@ static int opt_parse_track(const struct option *opt, const char *arg, int not)
> static int fetch_remote(const char *name)
> {
> const char *argv[] = { "fetch", name, NULL, NULL };
> - if (verbose) {
> + if (verbosity > 0) {
> argv[1] = "-v";
> argv[2] = name;
> + } else if (verbosity < 0) {
> + argv[1] = "-q";
> + argv[2] = name;
> }
> printf("Updating %s\n", name);
Should --quiet also affect this "Updating %s" line?
Actually, I have often wished for a way to shut up this line but keep
fetch at its normal verbosity. Fetch very sanely says nothing if there
is nothing to update, but you still get this "Updating" junk line, even
if nothing is transferred. But that would probably need an extra
"--quiet-remote" option to handle separately from what we pass to fetch.
-Peff
next prev parent reply other threads:[~2009-12-06 14:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-06 0:00 [PATCH] Allow --quiet option to git remote, particularly for `git remote update` Alex Vandiver
2009-12-06 2:04 ` Junio C Hamano
2009-12-07 7:23 ` Alex Vandiver
2009-12-06 14:50 ` Jeff King [this message]
2009-12-07 6:15 ` Alex Vandiver
2009-12-07 6:40 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091206145000.GC26440@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=alex@chmrr.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).