From: Nicolas Sebrecht <nicolas.s.dev@gmx.fr>
To: Jeff King <peff@peff.net>
Cc: Nicolas Pitre <nico@fluxnic.net>,
Tomas Carnecky <tom@dbservice.com>,
git list <git@vger.kernel.org>,
Nicolas Sebrecht <nicolas.s.dev@gmx.fr>
Subject: Re: clang static analyzer
Date: Mon, 7 Dec 2009 00:49:02 +0100 [thread overview]
Message-ID: <20091206234902.GA12932@vidovic> (raw)
In-Reply-To: <20091206160436.GA7140@coredump.intra.peff.net>
The 06/12/09, Jeff King wrote:
> On Sun, Dec 06, 2009 at 10:39:56AM -0500, Nicolas Pitre wrote:
>
> > > 2. If it is a false positive, see what it would take to silence clang
> > > and submit a patch. I don't think we are opposed to annotations
> > > that help analysis tools as long as those annotations aren't too
> > > intrusive or make the code less readable.
> >
> > I'm a bit skeptical here. Going down that route might mean that we'll
> > eventually have to add all sort of crap to accommodate everyone's
> > preferred static analysis tool of the day. Would be far nicer to try to
> > make those tools more intelligent instead, or at least make them
> > understand an out-of-line annotation format that does not clutter the
> > code itself.
>
> To be clear, I am a bit skeptical, too.
Me too. I have no idea about how clang works but if there are enough
work done to support such a tool in the code itself, it would be sad to
not share and promote this work. If Junio cares enough himself, he could
set up a public dedicated branch. Now if he doesn't, it's not necessary
at all. Tomas or anyone else with enough time and motivation can fork
the repository for this purpose.
The latter option would be good and appreciated by everybody here, I
think.
--
Nicolas Sebrecht
next prev parent reply other threads:[~2009-12-06 23:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-06 6:11 clang static analyzer Tomas Carnecky
2009-12-06 14:57 ` Jeff King
2009-12-06 15:39 ` Nicolas Pitre
2009-12-06 16:04 ` Jeff King
2009-12-06 23:49 ` Nicolas Sebrecht [this message]
2009-12-07 0:18 ` Junio C Hamano
2009-12-07 0:26 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091206234902.GA12932@vidovic \
--to=nicolas.s.dev@gmx.fr \
--cc=git@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=peff@peff.net \
--cc=tom@dbservice.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox