git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Alex Vandiver <alex@chmrr.net>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH] Allow --quiet option to git remote, particularly for `git remote update`
Date: Mon, 7 Dec 2009 01:40:07 -0500	[thread overview]
Message-ID: <20091207064007.GA3664@coredump.intra.peff.net> (raw)
In-Reply-To: <1260156352-sup-6170@utwig>

On Mon, Dec 07, 2009 at 01:15:05AM -0500, Alex Vandiver wrote:

> At Sun Dec 06 09:50:00 -0500 2009, Jeff King wrote:
> > Should --quiet also affect this "Updating %s" line?
> 
> Looking at it more closely, I think this patch should -- but for
> reasons unrelated o your argument below.  The "Updating %s" line there
> is in fetch_remote, which is _only_ called during `git remote add -f`.
> It stands in for the "Fetching %s" line which `git fetch` (and `git
> remote update`) outputs, which (after this patch), _is_ controlled by
> --quiet.

Ah, sorry, this has actually changed since the last time I looked at it
closely, as a result of 9c4a036 (Teach the --all option to 'git fetch',
2009-11-09). So nevermind my complaint...it has actually been addressed
separately (I didn't notice because I have been suppressing the output
by redirecting stdout for some time).

> Thus I feel like "Updating %s" should change to "Fetching %s" for both
> consistency and explicitness, and should also be controlled by
> --quiet.  The --quiet-remote option is an entirely different bikeshed,
> which I don't have a strong opinion on, offhand.

Yes, I agree (that it should be quieted, and that it should say
"Fetching").  My --quiet-remote argument is now pointless as of
9c4a036b.

-Peff

      reply	other threads:[~2009-12-07  6:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-06  0:00 [PATCH] Allow --quiet option to git remote, particularly for `git remote update` Alex Vandiver
2009-12-06  2:04 ` Junio C Hamano
2009-12-07  7:23   ` Alex Vandiver
2009-12-06 14:50 ` Jeff King
2009-12-07  6:15   ` Alex Vandiver
2009-12-07  6:40     ` Jeff King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091207064007.GA3664@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=alex@chmrr.net \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).