From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Couder Subject: Re: [PATCH RFC] rebase: add --revisions flag Date: Wed, 9 Dec 2009 07:52:51 +0100 Message-ID: <200912090752.51609.chriscool@tuxfamily.org> References: <20091208144740.GA30830@redhat.com> <200912090630.28506.chriscool@tuxfamily.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Junio C Hamano , Stephan Beyer , Christian Couder , Daniel Barkalow , Git List , Johannes Schindelin To: Sverre Rabbelier X-From: git-owner@vger.kernel.org Wed Dec 09 07:50:33 2009 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1NIGNb-0001by-J5 for gcvg-git-2@lo.gmane.org; Wed, 09 Dec 2009 07:50:31 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756631AbZLIGuU convert rfc822-to-quoted-printable (ORCPT ); Wed, 9 Dec 2009 01:50:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756066AbZLIGuT (ORCPT ); Wed, 9 Dec 2009 01:50:19 -0500 Received: from smtp3-g21.free.fr ([212.27.42.3]:37624 "EHLO smtp3-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755182AbZLIGuT convert rfc822-to-8bit (ORCPT ); Wed, 9 Dec 2009 01:50:19 -0500 Received: from smtp3-g21.free.fr (localhost [127.0.0.1]) by smtp3-g21.free.fr (Postfix) with ESMTP id 39C368180A4; Wed, 9 Dec 2009 07:50:16 +0100 (CET) Received: from bureau.boubyland (gre92-7-82-243-130-161.fbx.proxad.net [82.243.130.161]) by smtp3-g21.free.fr (Postfix) with ESMTP id E5F628180E2; Wed, 9 Dec 2009 07:50:13 +0100 (CET) User-Agent: KMail/1.9.9 In-Reply-To: <200912090630.28506.chriscool@tuxfamily.org> Content-Disposition: inline Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On mercredi 09 d=E9cembre 2009, Christian Couder wrote: > Hi, > > On mardi 08 d=E9cembre 2009, Sverre Rabbelier wrote: > > Heya, > > > > On Tue, Dec 8, 2009 at 21:22, Junio C Hamano wr= ote: > > > But I think it is a reasonable thing to _implement_ the feature t= o > > > range-pick commits reusing the sequencing logic already in "rebas= e" > > > and "rebase -i". =A0That essentially is what we wanted to do with= "git > > > sequencer" that would be a sequencing logic backend shared among > > > rebase, cherry-pick, and perhaps am. > > > > Speaking of which, what's the status of git sequencer? I seem to > > remember some activity recently to slowly rewrite git rebase in c, = but > > I haven't seen anything since then. Is it still moving forward? Is > > anyone interested in doing so? Just curious... > > Last June and July, I sent some patch series to port "rebase -i" to C > using code from the sequencer project. My goal was to save some > interesting code from the sequencer GSoC 2008 project and at the same > time to move forward "rebase -i" code toward a sequencer. > > But Dscho and Junio didn't like the fact that the code from the seque= ncer > I added was duplicating existing code and was not properly refactored= , > though it also added things that would be needed later for the sequen= cer. > My plan was to refactor later, once I had a sequencer, but Junio and > Dscho did not like that plan. They said it would be a too big mainten= ance > burden. > > So I agreed to not duplicate any existing code and to properly refact= or > everything. And I have been trying to take interesting and useful cod= e > from the sequencer project and to integrate it into existing commands= =2E > And this is why I sent yesterday the 4th version of my '"git reset > --merge" related improvements' patch series. After that I plan to work on cherry-pick and that could be useful to=20 implement something like "git cherry-pick A..B". See patch 11/15 from Stephan Beyer in my last "port rebase -i to C" ser= ies:=20 http://thread.gmane.org/gmane.comp.version-control.git/127256/focus=3D1= 27259 Regards, Christian.