From: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
To: Johannes Sixt <j6t@kdbg.org>
Cc: git@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] Report exec errors from run-command
Date: Fri, 25 Dec 2009 19:15:05 +0200 [thread overview]
Message-ID: <20091225171505.GA11830@Knoppix> (raw)
In-Reply-To: <200912251539.35201.j6t@kdbg.org>
On Fri, Dec 25, 2009 at 03:39:34PM +0100, Johannes Sixt wrote:
>
> The only really *important* errno of a failed exec is ENOENT. For this case,
> wouldn't it be easier to do the PATH lookup manually in the parent (before
> the fork()), and use execv() in the forked child rather than execvp()?
In fact there is API for getting all valid commands on $PATH for given command
prefix. That would take care of ENOENT and most of EACCESS.
But OTOH, its nice to be able to report any error.
-Ilari
next prev parent reply other threads:[~2009-12-25 17:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-24 17:49 [RFC PATCH 0/2] Report remote helper exec failures Ilari Liusvaara
2009-12-24 17:49 ` [RFC PATCH 1/2] Report exec errors from run-command Ilari Liusvaara
2009-12-25 7:35 ` Junio C Hamano
2009-12-25 7:46 ` Junio C Hamano
2009-12-25 8:40 ` Junio C Hamano
2009-12-25 9:51 ` Ilari Liusvaara
2009-12-25 14:39 ` Johannes Sixt
2009-12-25 17:15 ` Ilari Liusvaara [this message]
2009-12-24 17:49 ` [RFC PATCH 2/2] Improve transport helper exec failure reporting Ilari Liusvaara
2009-12-25 7:44 ` Junio C Hamano
2009-12-25 9:32 ` Ilari Liusvaara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091225171505.GA11830@Knoppix \
--to=ilari.liusvaara@elisanet.fi \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).