From: "Shawn O. Pearce" <spearce@spearce.org>
To: Nanako Shiraishi <nanako3@lavabit.com>
Cc: Junio C Hamano <gitster@pobox.com>, Sung Pae <sung@metablu.com>,
git@vger.kernel.org
Subject: Re: [PATCH] Wrap completions in `type git' conditional statement.
Date: Tue, 29 Dec 2009 07:02:17 -0800 [thread overview]
Message-ID: <20091229150217.GB6152@spearce.org> (raw)
In-Reply-To: <20091229200530.6117@nanako3.lavabit.com>
Nanako Shiraishi <nanako3@lavabit.com> wrote:
> Junio, could you tell us what happened to this thread?
>
> The patch avoids failing completion script when git is not there.
> No discussion.
Actually, that's probably my fault. I never sent an ack or nak,
or anything else really, on this thread.
Originally this was because the completion was trying to run git
as it loaded. In 1.6.6 this is no longer true, the completion list
is generated lazily on demand during the first completion attempt.
With the lazy loading, I didn't see a reason to add this ugly block
around the entire script.
--
Shawn.
next prev parent reply other threads:[~2009-12-29 15:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-12 9:56 [PATCH] Wrap completions in `type git' conditional statement Sung Pae
2009-12-29 11:05 ` Nanako Shiraishi
2009-12-29 15:02 ` Shawn O. Pearce [this message]
2009-12-29 16:58 ` Junio C Hamano
2009-12-29 21:54 ` Nanako Shiraishi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091229150217.GB6152@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nanako3@lavabit.com \
--cc=sung@metablu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).