From: Johan Herland <johan@herland.net>
To: git@vger.kernel.org
Cc: Kevin Ballard <kevin@sb.org>,
"Shawn O. Pearce" <spearce@spearce.org>,
trast@student.ethz.ch
Subject: Re: __git_ps1 not showing submodule dirty state
Date: Thu, 31 Dec 2009 02:40:07 +0100 [thread overview]
Message-ID: <200912310240.07741.johan@herland.net> (raw)
In-Reply-To: <A98B75F4-B9BD-4CB4-9335-754C59ECB64F@sb.org>
On Wednesday 30 December 2009, Kevin Ballard wrote:
> Why does the __git_ps1 function in git-completion.bash explicitly ignore
> submodules when showing the GIT_PS1_SHOWDIRTYSTATE status? The most
> common issue with my current repository is not realizing when submodules
> need to be updated because I blindly trust my prompt to tell me when I
> have dirty state.
According to git blame, it has been there since GIT_PS1_SHOWDIRTYSTATE was
introduced in 738a94a... by Thomas Rast (CCed), but the commit message does
not say why submodules are explicitly ignored.
FWIW, I agree with Kevin, and would like changed submodules to be included
in the status.
...Johan
--
Johan Herland, <johan@herland.net>
www.herland.net
next prev parent reply other threads:[~2009-12-31 1:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-30 21:46 __git_ps1 not showing submodule dirty state Kevin Ballard
2009-12-31 1:40 ` Johan Herland [this message]
2009-12-31 11:48 ` [PATCH] bash completion: factor submodules into " Thomas Rast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912310240.07741.johan@herland.net \
--to=johan@herland.net \
--cc=git@vger.kernel.org \
--cc=kevin@sb.org \
--cc=spearce@spearce.org \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).