From: Andreas Gruenbacher <agruen@suse.de>
To: git@vger.kernel.org
Subject: base85: Two tiny fixes
Date: Thu, 7 Jan 2010 15:58:29 +0100 [thread overview]
Message-ID: <201001071558.30065.agruen@suse.de> (raw)
While looking at the base85 code I found a bug in the debug code and an
unnecessary call. You may want to have a look at the two fixes here:
http://www.kernel.org/pub/scm/linux/kernel/git/agruen/git.git
There is another little oddity in the way the de85 table is set up: 0
indicates an invalid entry; to avoid this from clashing with a valid entry,
valid entries are incremented by one and decremented again while decoding.
This leads to slightly worse code than using a negative number to indicate
invalid values (and avoiding to increment/decrement).
Andreas
next reply other threads:[~2010-01-07 15:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 14:58 Andreas Gruenbacher [this message]
2010-01-07 17:58 ` base85: Two tiny fixes Nicolas Pitre
2010-01-08 13:02 ` Andreas Gruenbacher
2010-01-08 13:39 ` [PATCH 1/3] base85 debug code: Fix length byte calculation Andreas Gruenbacher
2010-01-08 13:39 ` [PATCH 2/3] base85: No need to initialize the decode table in encode_85 Andreas Gruenbacher
2010-01-08 15:46 ` Michael J Gruber
2010-01-08 15:55 ` Junio C Hamano
2010-01-08 16:17 ` [PATCH] base85: encode85() does not use the decode table Andreas Gruenbacher
2010-01-08 16:22 ` [PATCH] base85: encode_85() " Andreas Gruenbacher
2010-01-08 13:40 ` [PATCH 3/3] base85: Make the code more obvious instead of explaining the non-obvious Andreas Gruenbacher
2010-01-08 23:15 ` A Large Angry SCM
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001071558.30065.agruen@suse.de \
--to=agruen@suse.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).