From: Johannes Sixt <j6t@kdbg.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Nanako Shiraishi <nanako3@lavabit.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git@vger.kernel.org
Subject: Re: [PATCH (v2) 2/2] rebase -i: teach --onto A...B syntax
Date: Thu, 7 Jan 2010 22:10:55 +0100 [thread overview]
Message-ID: <201001072210.55727.j6t@kdbg.org> (raw)
In-Reply-To: <7vtyux3bx1.fsf@alter.siamese.dyndns.org>
On Donnerstag, 7. Januar 2010, Junio C Hamano wrote:
> I was tempted to suggest having a common helper function,
> but as Dscho mentioned "rebase -i" implementation does not share much with
> "rebase" (even though it shares the external command line interface from
> the end user's point of view), and I don't see a readily available place
> (other than in git-sh-setup) to do so.
>
> Ideas?
1. Split git-rebase--merge.sh and git-rebase--am.sh backends off of
git-rebase.sh. Have git-rebase.sh dispatch to
git-rebase--{am,merge,interactive}.sh as appropriate.
2. Unify command line parsing from git-rebase--*.sh in git-rebase.sh. The
git-rebase--*.sh can now simply refer to shell variables that were set by
command line switches (the backends must be invoked using the . (dot)
command).
3. Place common functionality like the one above in git-rebase.sh.
-- Hannes
next prev parent reply other threads:[~2010-01-07 21:11 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-04 8:39 What's cooking in git.git (Jan 2010, #01; Mon, 04) Junio C Hamano
2010-01-04 16:19 ` Matthieu Moy
2010-01-04 19:10 ` Junio C Hamano
2010-01-04 16:29 ` Johannes Sixt
2010-01-05 1:35 ` Junio C Hamano
2010-01-05 4:20 ` Jeff King
2010-01-05 5:18 ` Junio C Hamano
2010-01-05 20:49 ` Johannes Sixt
2010-01-06 7:47 ` Junio C Hamano
2010-01-06 9:08 ` Johannes Sixt
2010-01-06 17:04 ` Junio C Hamano
2010-01-05 5:57 ` Junio C Hamano
2010-01-05 6:40 ` Jeff King
2010-01-05 7:28 ` Tay Ray Chuan
2010-01-05 8:16 ` [PATCH] Teach --[no-]rerere-autoupdate option to merge, revert and friends Junio C Hamano
2010-01-05 11:31 ` What's cooking in git.git (Jan 2010, #01; Mon, 04) Johan Herland
2010-01-05 11:56 ` Ilari Liusvaara
2010-01-06 1:04 ` Junio C Hamano
2010-01-06 10:18 ` Nanako Shiraishi
2010-01-06 11:29 ` Johannes Schindelin
2010-01-06 17:07 ` Junio C Hamano
2010-01-07 11:05 ` [PATCH (v2) 1/2] rebase: fix --onto A...B parsing and add tests Nanako Shiraishi
2010-01-07 11:05 ` [PATCH (v2) 2/2] rebase -i: teach --onto A...B syntax Nanako Shiraishi
2010-01-07 20:19 ` Junio C Hamano
2010-01-07 21:10 ` Johannes Sixt [this message]
2010-01-08 20:16 ` Avery Pennarun
2010-01-08 20:22 ` Sverre Rabbelier
2010-01-08 20:31 ` Avery Pennarun
2010-01-08 20:37 ` Sverre Rabbelier
2010-01-08 23:21 ` A Large Angry SCM
2010-01-09 1:36 ` Johannes Schindelin
2010-01-09 21:02 ` Avery Pennarun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001072210.55727.j6t@kdbg.org \
--to=j6t@kdbg.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nanako3@lavabit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).