From: Johannes Sixt <j6t@kdbg.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>, git@vger.kernel.org
Subject: Re: [PATCH 3/4] start_command: detect execvp failures early
Date: Thu, 14 Jan 2010 22:53:19 +0100 [thread overview]
Message-ID: <201001142253.19595.j6t@kdbg.org> (raw)
In-Reply-To: <7viqb49xwb.fsf@alter.siamese.dyndns.org>
On Donnerstag, 14. Januar 2010, Junio C Hamano wrote:
> Johannes Sixt <j6t@kdbg.org> writes:
> > Previously, failures during execvp could be detected only by
> > finish_command. However, in some situations it is beneficial for the
> > parent process to know earlier that the child process will not run.
> >
> > The idea to use a pipe to signal failures to the parent process and
> > the test case were lifted from patches by Ilari Liusvaara.
>
> I wonder if we can do this without pipe, perhaps using "vfork, exec, then
> update a variable"....
Except that some systems implement vfork(2) in terms of fork(2), I heard.
Moreover, I think that we do way too many things before the exec; isn't that
dangerous?
-- Hannes
next prev parent reply other threads:[~2010-01-14 21:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-09 13:45 [RFC PATCH v2 0/2] Imporove remote helper exec failure reporting Ilari Liusvaara
2010-01-09 13:45 ` [RFC PATCH v2 1/2] Report exec errors from run-command Ilari Liusvaara
2010-01-10 13:04 ` [PATCH 0/4] Detect exec errors in start_command early Johannes Sixt
2010-01-10 13:07 ` [PATCH 1/4] start_command: report child process setup errors to the parent's stderr Johannes Sixt
2010-01-10 13:08 ` [PATCH 2/4] run-command: move wait_or_whine earlier Johannes Sixt
2010-01-10 13:11 ` [PATCH 3/4] start_command: detect execvp failures early Johannes Sixt
2010-01-14 21:31 ` Junio C Hamano
2010-01-14 21:53 ` Johannes Sixt [this message]
2010-01-14 22:40 ` Junio C Hamano
2010-01-10 13:18 ` [PATCH 4/4] Improve error message when a transport helper was not found Johannes Sixt
2010-01-09 13:45 ` [RFC PATCH v2 2/2] Improve transport helper exec failure reporting Ilari Liusvaara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001142253.19595.j6t@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ilari.liusvaara@elisanet.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).