From: Andreas Gruenbacher <agruen@suse.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] builtin-apply.c: Skip filenames without enough components
Date: Sun, 17 Jan 2010 03:44:34 +0100 [thread overview]
Message-ID: <201001170344.34525.agruen@suse.de> (raw)
In-Reply-To: <7vr5ppa2st.fsf@alter.siamese.dyndns.org>
On Sunday 17 January 2010 03:22:10 am Junio C Hamano wrote:
> Tests?
Sure if you think it's worth a regression test ... "git apply -p2" of the
following patch fails with "fatal: git diff header lacks filename information
when removing 2 leading pathname components (line 6)" with the fix, and
creates b/f without:
diff --git a/f b/f
new file mode 100644
index 0000000..6a69f92
--- /dev/null
+++ b/f
@@ -0,0 +1 @@
+f
(Some earlier versions of git failed with "fatal: git apply: bad git-diff -
inconsistent new filename on line 5" in this case.)
Andreas
next prev parent reply other threads:[~2010-01-17 2:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-17 2:05 [PATCH] builtin-apply.c: Skip filenames without enough components Andreas Gruenbacher
2010-01-17 2:22 ` Junio C Hamano
2010-01-17 2:44 ` Andreas Gruenbacher [this message]
2010-01-18 10:22 ` Nanako Shiraishi
2010-01-18 19:57 ` Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001170344.34525.agruen@suse.de \
--to=agruen@suse.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).