From: "Shawn O. Pearce" <spearce@spearce.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git <git@vger.kernel.org>
Subject: Re: why is tagger header optional?
Date: Mon, 18 Jan 2010 22:37:43 -0800 [thread overview]
Message-ID: <20100119063743.GD23212@spearce.org> (raw)
In-Reply-To: <7vfx62bo0i.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> wrote:
> "Shawn O. Pearce" <spearce@spearce.org> writes:
> > Junio C Hamano <gitster@pobox.com> wrote:
> >> "Shawn O. Pearce" <spearce@spearce.org> writes:
> >>
> >> > So why is it legal to omit the tagger header from a tag?
> >> >
> >> > E.g. the Linux kernel tag v2.6.12 has no tagger header:
> >>
> >> We didn't.add tagger line until c818566 ([PATCH] Update tags to record who
> >> made them, 2005-07-14), which is v0.99.1~9
> >>
> >> Linux 2.6.12 is a lot older than that. v2.6.13-rc4 in late July is the
> >> first one with tagger.
> >
> > Ugh. So its like the 100640 or whatever mode tags in the kernel
> > trees that are also considered bogus by today's standards, but have
> > to be allowed because of the kernel history.
>
> Yeah; don't we have "fsck --strict" or something to take the distinction
> into account, though? I don't recall if lack of tagger triggers the check
> offhand and I am too lazy to check.
I don't think it does under --strict. But yea, we do have --strict
for the non-kernel repositories.
This came up because Gerrit Code Review asks JGit to do fsck during
receive of objects from a client, JGit's tag fsck is too strict
and demands a "tagger " header, but someone was trying to push this
old tag from the Linux kernel into an empty repository.
I'll have to relax our tag fsck code in JGit and make the header
optional.
--
Shawn.
next prev parent reply other threads:[~2010-01-19 6:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 6:09 why is tagger header optional? Shawn O. Pearce
2010-01-19 6:31 ` Junio C Hamano
2010-01-19 6:32 ` Shawn O. Pearce
2010-01-19 6:35 ` Junio C Hamano
2010-01-19 6:37 ` Shawn O. Pearce [this message]
2010-01-19 6:44 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100119063743.GD23212@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).