From: Andreas Krey <a.krey@gmx.de>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: tzachi perelstein <tzachi_perelstein@yahoo.com>, git@vger.kernel.org
Subject: Re: git-describe recognize modified files
Date: Tue, 19 Jan 2010 13:21:22 +0100 [thread overview]
Message-ID: <20100119122122.GA28667@inner.home.ulmdo.de> (raw)
In-Reply-To: <alpine.DEB.1.00.1001191134130.3164@intel-tinevez-2-302>
On Tue, 19 Jan 2010 11:35:41 +0000, Johannes Schindelin wrote:
...
> > To solve this issue, in addition to git-describe, my do_version script
> > also run git-status, and if there are "modified:" files then it
> > concatenates the string "+dirty" to output of git-describe.
>
> The problem is that this does not describe the exact version you used very
> well.
I (and probably the original poster) don't care that much; for me the
important information is that the binary (or whatever) was not built
from the exact committed state. Thus the question is whether the
second two lines of
BUILDINFO=git-`git describe --abbrev=16 --always HEAD 2>/dev/null`
git update-index -q --refresh
test -z "`git diff-index --name-only HEAD --`" || BUILDINFO="$BUILDINFO.dirty"
(after GIT-VERSION-GEN) are worth to be integrated into git-describe?
(And whether it should also say '.dirty'
when there are untracked files present.
Or either for submodules.)
Andreas
next prev parent reply other threads:[~2010-01-19 12:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 9:53 git-describe recognize modified files tzachi perelstein
2010-01-19 10:35 ` Johannes Schindelin
2010-01-19 12:21 ` Andreas Krey [this message]
2010-01-19 12:49 ` Jakub Narebski
2010-01-19 13:07 ` tzachi perelstein
2010-01-19 12:59 ` tzachi perelstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100119122122.GA28667@inner.home.ulmdo.de \
--to=a.krey@gmx.de \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=tzachi_perelstein@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).