From: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] Makefile: honor NO_CURL when setting REMOTE_CURL_* variables
Date: Tue, 19 Jan 2010 18:58:58 +0200 [thread overview]
Message-ID: <20100119165858.GA24065@Knoppix> (raw)
In-Reply-To: <1263915552-32537-1-git-send-email-j6t@kdbg.org>
On Tue, Jan 19, 2010 at 04:39:12PM +0100, Johannes Sixt wrote:
> Previously, these variables were set before there was a chance to set
> NO_CURL.
>
> This made a difference only during 'make install', because by installing
> $(REMOTE_CURL_ALIASES), the rule tries to access $(REMOTE_CURL_PRIMARY),
> which was never installed. On Windows, this fails; on Unix, stale symbolic
> links are created.
<snip patch>
I didn't even compile-test it, but based on quick look I don't see any
obivous mistakes. There are no references to REMOTE_CURL_* in section
moved over, and the variable values should not differ unless section skipped
sets NO_CURL. So:
Acked-by: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
-Ilari
next prev parent reply other threads:[~2010-01-19 16:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 15:39 [PATCH] Makefile: honor NO_CURL when setting REMOTE_CURL_* variables Johannes Sixt
2010-01-19 16:58 ` Ilari Liusvaara [this message]
2010-01-19 23:31 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100119165858.GA24065@Knoppix \
--to=ilari.liusvaara@elisanet.fi \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).