From: Joey Hess <joey@kitenet.net>
To: git@vger.kernel.org
Subject: Re: git notes: notes
Date: Wed, 20 Jan 2010 14:56:26 -0500 [thread overview]
Message-ID: <20100120195626.GA6641@gnu.kitenet.net> (raw)
In-Reply-To: <7vhbqg376b.fsf@alter.siamese.dyndns.org>
[-- Attachment #1: Type: text/plain, Size: 1037 bytes --]
Junio C Hamano wrote:
> Let me ask a stupid question. Did the output change before and after the
> notes code even when your history does not have notes?
No.
> >> > Might be worth documenting in release notes, maybe too late now though.
>
> This depends on the answer to the above question. If the answers is "No",
> then I don't see the need to say much more than "New 'git notes' feature
> allows comments applied to existing commits after the fact to be shown by
> log and friends". If it is "Yes", we should fix the code not to change
> the output.
>
> In any case, "log" is still a Porcelain, so it is understandable that by
> triggering a new feature you would get output from the new feature. It is
> called progress ;-)
Do you think it makes sense for even git log --format=format:%s to be
porcelain and potentially change when new features are used? Seems to
me that parts of git log walk the line between porcelain and plumbing.
So it's not clear which parts are safe to use.
--
see shy jo
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2010-01-20 19:56 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-20 5:03 git notes: notes Joey Hess
2010-01-20 9:48 ` Thomas Rast
2010-01-20 18:14 ` Joey Hess
2010-01-20 10:48 ` Johan Herland
2010-01-20 18:24 ` Joey Hess
2010-01-20 19:30 ` Junio C Hamano
2010-01-20 19:56 ` Joey Hess [this message]
2010-01-20 20:10 ` Junio C Hamano
2010-01-20 20:36 ` Joey Hess
2010-01-20 20:54 ` Jeff King
2010-01-20 20:59 ` Junio C Hamano
2010-01-20 21:31 ` Jeff King
2010-01-20 21:41 ` Jeff King
2010-01-20 22:07 ` Junio C Hamano
2010-01-20 22:21 ` Jeff King
2010-01-20 21:02 ` Michael J Gruber
2010-01-20 21:08 ` Junio C Hamano
2010-01-20 21:36 ` Jeff King
2010-01-20 21:59 ` Junio C Hamano
2010-01-20 22:25 ` Jeff King
2010-01-20 22:33 ` Junio C Hamano
2010-01-20 22:58 ` Johannes Schindelin
2010-01-20 23:06 ` Jeff King
2010-01-20 23:14 ` Junio C Hamano
2010-01-21 2:54 ` Johan Herland
2010-01-21 3:03 ` Junio C Hamano
2010-01-21 3:37 ` Junio C Hamano
2010-01-21 8:45 ` Michael J Gruber
2010-01-24 14:20 ` Matthieu Moy
2010-01-24 14:27 ` Sverre Rabbelier
2010-01-21 2:05 ` Johan Herland
2010-01-21 3:59 ` Johannes Schindelin
2010-01-21 4:05 ` Joey Hess
2010-01-27 11:55 ` Johan Herland
2010-01-25 18:08 ` John Koleszar
2010-01-27 20:01 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100120195626.GA6641@gnu.kitenet.net \
--to=joey@kitenet.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).