From: Johannes Sixt <j6t@kdbg.org>
To: Michael Lukashov <michael.lukashov@gmail.com>
Cc: git@vger.kernel.org, "Andrzej K. Haczewski" <ahaczewski@gmail.com>
Subject: Re: [PATCH] Windows: Remove dependency on pthreadGC2.dll
Date: Sun, 24 Jan 2010 20:03:33 +0100 [thread overview]
Message-ID: <201001242003.33703.j6t@kdbg.org> (raw)
In-Reply-To: <1264327830-4204-1-git-send-email-michael.lukashov@gmail.com>
On Sonntag, 24. Januar 2010, Michael Lukashov wrote:
> Commit 44626dc7 (MSVC: Windows-native implementation for subset
> of threads API, 2010-01-15) introduces builtin replacement of
> pthreadGC2.dll functionality, thus we can completely drop
> dependency on this dll.
Duh! This means that when I tested above-mentioned patch, I actually was using
pthread.h from msysgit instead of compat/win32/pthread.h, and didn't test it
at all (note: MinGW version; MSVC was fine because it had the right includes
all the time). This patch passes the test suite and a 'git gc --aggressive':
Acked-by: Johannes Sixt <j6t@kdbg.org>
-- Hannes
prev parent reply other threads:[~2010-01-24 19:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-24 10:10 [PATCH] Windows: Remove dependency on pthreadGC2.dll Michael Lukashov
2010-01-24 19:03 ` Johannes Sixt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001242003.33703.j6t@kdbg.org \
--to=j6t@kdbg.org \
--cc=ahaczewski@gmail.com \
--cc=git@vger.kernel.org \
--cc=michael.lukashov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).