From: Johannes Sixt <j6t@kdbg.org>
To: Michael Lukashov <michael.lukashov@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Windows: avoid static dependency on advapi32.dll
Date: Sun, 24 Jan 2010 20:20:08 +0100 [thread overview]
Message-ID: <201001242020.08534.j6t@kdbg.org> (raw)
In-Reply-To: <1264359231-4672-1-git-send-email-michael.lukashov@gmail.com>
On Sonntag, 24. Januar 2010, Michael Lukashov wrote:
> This DLL is used to get default user name. By looking
> up the only function that we need at runtime, we can
> avoid the startup costs of this DLL.
Sorry, no. This doesn't work. Even though git.exe does no longer depend on
advapi32.dll directly, it does so indirectly (via ws_32.dll). This patch is
not an improvement, therefore: NAK.
-- Hannes
prev parent reply other threads:[~2010-01-24 19:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-24 18:53 [PATCH] Windows: avoid static dependency on advapi32.dll Michael Lukashov
2010-01-24 19:20 ` Johannes Sixt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001242020.08534.j6t@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=michael.lukashov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).