From: Jeff King <peff@peff.net>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] git_connect: use use_shell instead of explicit "sh", "-c"
Date: Mon, 25 Jan 2010 08:01:26 -0500 [thread overview]
Message-ID: <20100125130125.GA10036@coredump.intra.peff.net> (raw)
In-Reply-To: <4B5D8F6C.1040407@viscovery.net>
On Mon, Jan 25, 2010 at 01:32:44PM +0100, Johannes Sixt wrote:
> This is a followup to ac0ba18 (run-command: convert simple callsites to
> use_shell, 2009-12-30), for consistency.
>
> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
> ---
> Jeff,
>
> is there a reason that this was not part of the original patch?
No, I must have just missed it (I don't remember omitting it for a
particular reason at the time, and after looking at it now, it looks
sane to me).
After this, git grep '"sh"' turns up only two uses: one in the
run-command code use_shell code path, and the other in builtin-help.c.
The one in builtin-help is hard to change, as it relies on direct exec
instead of run-command.
-Peff
prev parent reply other threads:[~2010-01-25 13:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-25 12:32 [PATCH] git_connect: use use_shell instead of explicit "sh", "-c" Johannes Sixt
2010-01-25 13:01 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100125130125.GA10036@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).