From: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
To: Tor Arvid Lund <torarvid@gmail.com>
Cc: Daniel Barkalow <barkalow@iabervon.org>, git@vger.kernel.org
Subject: Re: [PATCH not-for-mainline] Implement git-vcs-p4
Date: Wed, 27 Jan 2010 17:56:36 +0200 [thread overview]
Message-ID: <20100127155636.GA18210@Knoppix> (raw)
In-Reply-To: <1a6be5fa1001270318h4ac8ac3bnaba48787a5b3efa6@mail.gmail.com>
On Wed, Jan 27, 2010 at 12:18:35PM +0100, Tor Arvid Lund wrote:
> Then, I did 'git fetch', and got a seg fault. I got around it by
> commenting out a line:
>
> diff --git a/transport.c b/transport.c
> index 7714fdb..5b404f7 100644
> --- a/transport.c
> +++ b/transport.c
> @@ -924,7 +924,7 @@ struct transport *transport_get(struct remote
> *remote, const char *url)
> ret->url = url;
>
> /* In case previous URL had helper forced, reset it. */
> - remote->foreign_vcs = NULL;
> +/* remote->foreign_vcs = NULL;*/
>
> /* maybe it is a foreign URL? */
> if (url) {
>
Hmm... And just commenting out that line will break case if you have
push URL using remote helpers and second one for same remote that
doesn't.
I'll look into that issue.
-Ilari
next prev parent reply other threads:[~2010-01-27 15:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-25 21:35 [PATCH not-for-mainline] Implement git-vcs-p4 Daniel Barkalow
2010-01-25 21:53 ` Sverre Rabbelier
2010-01-25 22:26 ` Daniel Barkalow
2010-01-25 22:28 ` Sverre Rabbelier
2010-01-27 11:18 ` Tor Arvid Lund
2010-01-27 15:56 ` Ilari Liusvaara [this message]
2010-01-27 16:49 ` Daniel Barkalow
2010-01-27 17:14 ` Ilari Liusvaara
2010-01-27 17:28 ` Daniel Barkalow
2010-01-27 17:49 ` Ilari Liusvaara
2010-01-27 17:18 ` Daniel Barkalow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100127155636.GA18210@Knoppix \
--to=ilari.liusvaara@elisanet.fi \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=torarvid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).