From mboxrd@z Thu Jan  1 00:00:00 1970
From: Johan Herland <johan@herland.net>
Subject: Re: [PATCHv12 01/23] Minor non-functional fixes to notes.c
Date: Wed, 27 Jan 2010 23:33:59 +0100
Message-ID: <201001272333.59125.johan@herland.net>
References: <1264593120-4428-1-git-send-email-johan@herland.net>
 <1264593120-4428-2-git-send-email-johan@herland.net>
 <7vwrz3nt2s.fsf@alter.siamese.dyndns.org>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-1
Content-Transfer-Encoding: 7BIT
Cc: git@vger.kernel.org
To: Junio C Hamano <gitster@pobox.com>
X-From: git-owner@vger.kernel.org Wed Jan 27 23:34:14 2010
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@lo.gmane.org
Received: from vger.kernel.org ([209.132.180.67])
	by lo.gmane.org with esmtp (Exim 4.69)
	(envelope-from <git-owner@vger.kernel.org>)
	id 1NaGSj-0005TI-02
	for gcvg-git-2@lo.gmane.org; Wed, 27 Jan 2010 23:34:13 +0100
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756362Ab0A0WeE (ORCPT <rfc822;gcvg-git-2@m.gmane.org>);
	Wed, 27 Jan 2010 17:34:04 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756360Ab0A0WeB
	(ORCPT <rfc822;git-outgoing>); Wed, 27 Jan 2010 17:34:01 -0500
Received: from smtp.getmail.no ([84.208.15.66]:43291 "EHLO
	get-mta-out02.get.basefarm.net" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1756350Ab0A0WeB (ORCPT
	<rfc822;git@vger.kernel.org>); Wed, 27 Jan 2010 17:34:01 -0500
Received: from smtp.getmail.no ([10.5.16.4]) by get-mta-out02.get.basefarm.net
 (Sun Java(tm) System Messaging Server 7.0-0.04 64bit (built Jun 20 2008))
 with ESMTP id <0KWX005IJG0ONG80@get-mta-out02.get.basefarm.net> for
 git@vger.kernel.org; Wed, 27 Jan 2010 23:34:00 +0100 (MET)
Received: from alpha.localnet ([84.215.68.234])
 by get-mta-in01.get.basefarm.net
 (Sun Java(tm) System Messaging Server 7.0-0.04 64bit (built Jun 20 2008))
 with ESMTP id <0KWX0003SG0NQS00@get-mta-in01.get.basefarm.net> for
 git@vger.kernel.org; Wed, 27 Jan 2010 23:34:00 +0100 (MET)
X-PMX-Version: 5.5.3.366731, Antispam-Engine: 2.7.0.366912,
 Antispam-Data: 2010.1.27.222119
User-Agent: KMail/1.12.4 (Linux/2.6.32-ARCH; KDE/4.3.4; x86_64; ; )
In-reply-to: <7vwrz3nt2s.fsf@alter.siamese.dyndns.org>
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/138204>

On Wednesday 27 January 2010, Junio C Hamano wrote:
> Johan Herland <johan@herland.net> writes:
> > Signed-off-by: Johan Herland <johan@herland.net>
> 
> Is it just me who goes "Huh?  Why is he sending a non-working fix?"

non-working? Does it break something for you?

> when seeing "non-functional fixes"?
> 
> I'd retitle it to "Cosmetic fixes" and apply.

Ok. Fixed locally, will be part of the next iteration.

> Thanks.

Thanks for the review.


...Johan

-- 
Johan Herland, <johan@herland.net>
www.herland.net