From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: [PATCH 1/3] test combinations of @{} syntax
Date: Thu, 28 Jan 2010 04:50:20 -0500 [thread overview]
Message-ID: <20100128095020.GA14253@coredump.intra.peff.net> (raw)
In-Reply-To: <20100128094446.GA14244@coredump.intra.peff.net>
Now that we have several different types of @{} syntax, it
is a good idea to test them together, which reveals some
failures.
Signed-off-by: Jeff King <peff@peff.net>
---
While this is conceptually similar to the tests in t0101, it feels
better to me to test features in combination only after they have been
tested by themselves. Thus a new script > 1507.
t/t1508-at-combinations.sh | 51 ++++++++++++++++++++++++++++++++++++++++++++
1 files changed, 51 insertions(+), 0 deletions(-)
create mode 100755 t/t1508-at-combinations.sh
diff --git a/t/t1508-at-combinations.sh b/t/t1508-at-combinations.sh
new file mode 100755
index 0000000..59f0463
--- /dev/null
+++ b/t/t1508-at-combinations.sh
@@ -0,0 +1,51 @@
+#!/bin/sh
+
+test_description='test various @{X} syntax combinations together'
+. ./test-lib.sh
+
+check() {
+test_expect_${3:-success} "$1 = $2" "
+ echo '$2' >expect &&
+ git log -1 --format=%s '$1' >actual &&
+ test_cmp expect actual
+"
+}
+nonsense() {
+test_expect_${2:-success} "$1 is nonsensical" "
+ test_must_fail git log -1 '$1'
+"
+}
+fail() {
+ "$@" failure
+}
+
+test_expect_success 'setup' '
+ test_commit master-one &&
+ test_commit master-two &&
+ git checkout -b upstream-branch &&
+ test_commit upstream-one &&
+ test_commit upstream-two &&
+ git checkout -b old-branch &&
+ test_commit old-one &&
+ test_commit old-two &&
+ git checkout -b new-branch &&
+ test_commit new-one &&
+ test_commit new-two &&
+ git config branch.old-branch.remote . &&
+ git config branch.old-branch.merge refs/heads/master &&
+ git config branch.new-branch.remote . &&
+ git config branch.new-branch.merge refs/heads/upstream-branch
+'
+
+check HEAD new-two
+check "@{1}" new-one
+check "@{-1}" old-two
+check "@{-1}@{1}" old-one
+check "@{u}" upstream-two
+check "@{u}@{1}" upstream-one
+fail check "@{-1}@{u}" master-two
+fail check "@{-1}@{u}@{1}" master-one
+fail nonsense "@{u}@{-1}"
+nonsense "@{1}@{u}"
+
+test_done
--
1.7.0.rc0.41.g538720
next prev parent reply other threads:[~2010-01-28 9:50 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-11 18:49 default behaviour for `gitmerge` (no arguments) Gareth Adams
2010-01-11 19:43 ` Junio C Hamano
2010-01-12 16:23 ` Jeff King
2010-01-12 18:11 ` Junio C Hamano
2010-01-12 18:25 ` Jeff King
2010-01-13 6:57 ` Junio C Hamano
2010-01-13 9:26 ` Johannes Schindelin
2010-01-13 9:47 ` Junio C Hamano
2010-01-13 11:04 ` Johannes Schindelin
2010-01-13 19:48 ` Junio C Hamano
2010-01-13 22:49 ` Johannes Schindelin
2010-01-13 23:13 ` Junio C Hamano
2010-01-20 9:38 ` [PATCH 0/2] @{u} updates Junio C Hamano
2010-01-20 9:38 ` [PATCH 1/2] t1506: more test for @{upstream} syntax Junio C Hamano
2010-01-26 13:07 ` Jeff King
2010-01-26 19:58 ` Junio C Hamano
2010-01-27 10:24 ` Jeff King
2010-01-27 18:50 ` Junio C Hamano
2010-01-28 8:52 ` Jeff King
2010-01-26 21:32 ` Junio C Hamano
2010-01-27 11:40 ` Jeff King
2010-01-27 19:10 ` Junio C Hamano
2010-01-28 9:44 ` Jeff King
2010-01-28 9:50 ` Jeff King [this message]
2010-01-28 9:52 ` [PATCH 2/3] fix parsing of @{-1}@{u} combination Jeff King
2010-01-28 9:56 ` [PATCH 3/3] reject @{-1} not at beginning of object name Jeff King
2010-01-28 20:02 ` Junio C Hamano
2010-01-29 11:22 ` Jeff King
2010-01-20 9:38 ` [PATCH 2/2] Teach @{upstream} syntax to strbuf_branchanme() Junio C Hamano
2010-01-20 13:08 ` [PATCH 0/2] @{u} updates Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100128095020.GA14253@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).