From: Michal Sojka <sojkam1@fel.cvut.cz>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, j.sixt@viscovery.net, Johannes.Schindelin@gmx.de
Subject: Re: [PATCHv3] filter-branch: Add tests for submodules
Date: Thu, 28 Jan 2010 10:02:02 +0100 [thread overview]
Message-ID: <201001281002.03232.sojkam1@fel.cvut.cz> (raw)
In-Reply-To: <7vfx5rnl0w.fsf@alter.siamese.dyndns.org>
On Thursday 28 of January 2010 01:14:07 Junio C Hamano wrote:
> Michal Sojka <sojkam1@fel.cvut.cz> writes:
> > There are three important tests:
>
> It is unnecessary and counterproductive to self-proclaim the importance of
> a patch or new tests. If anything, what are important are not tests
> themselves but the conditions that they check, so "Add tests to check
> three important cases:" is slightly more palatable.
>
> I'd suggest to just start with "Add three tests to make sure:".
OK
> > 1) 'rewrite submodule with another content' passes only with the
> > previous patch applied.
>
> Sorry, but I think I am missing some context here to understand this
> sentence. Which previous patch?
I should have sent both patches. Sorry for that. I'll send them now.
> > 2) 'checkout submodule during rewrite' demonstrates that it is not
> > possible to replace a submodule revision in tree-filter by checking
> > the submodule out and reseting the submodule's HEAD. Fails both
> > with and without the previous patch. This is because filter-branch
> > sets GIT_WORKING_TREE to "." which causes clone (called from
> > git-submodule) to fail.
>
> I thought you agreed with Hannes that this is not something we would even
> want to support?
Yes. I'm removing this test.
Cheers,
Michal
next prev parent reply other threads:[~2010-01-28 9:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-25 13:06 filter-branch fix and tests Michal Sojka
2010-01-25 13:06 ` [PATCH 1/2] filter-branch: Fix to allow replacing submodules with another content Michal Sojka
2010-01-25 13:06 ` [PATCH 2/2] filter-branch: Add tests for submodules Michal Sojka
[not found] ` <alpine.DEB.1.00.1001261939420.4641@intel-tinevez-2-302>
2010-01-27 15:49 ` [PATCH] filter-branch fix and tests Michal Sojka
2010-01-27 16:18 ` Johannes Sixt
2010-01-27 23:41 ` Michal Sojka
2010-01-27 23:55 ` [PATCHv3] filter-branch: Add tests for submodules Michal Sojka
2010-01-28 0:14 ` Junio C Hamano
2010-01-28 9:02 ` Michal Sojka [this message]
2010-01-28 9:08 ` [PATCHv4 1/2] filter-branch: Fix to allow replacing submodules with another content Michal Sojka
2010-01-28 9:08 ` [PATCHv4 2/2] filter-branch: Add tests for submodules in tree-filter Michal Sojka
2010-01-28 21:57 ` Junio C Hamano
2010-01-29 15:20 ` Michal Sojka
2010-01-29 15:27 ` [PATCHv5 1/2] filter-branch: Fix to allow replacing submodules with another content Michal Sojka
2010-01-29 15:27 ` [PATCHv5 2/2] filter-branch: Add tests for submodules in tree-filter Michal Sojka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001281002.03232.sojkam1@fel.cvut.cz \
--to=sojkam1@fel.cvut.cz \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).