From: Michal Sojka <sojkam1@fel.cvut.cz>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, j.sixt@viscovery.net, Johannes.Schindelin@gmx.de
Subject: Re: [PATCHv4 2/2] filter-branch: Add tests for submodules in tree-filter
Date: Fri, 29 Jan 2010 16:20:35 +0100 [thread overview]
Message-ID: <201001291620.35269.sojkam1@fel.cvut.cz> (raw)
In-Reply-To: <7vaavxlwoz.fsf@alter.siamese.dyndns.org>
On Thursday 28 of January 2010 22:57:16 Junio C Hamano wrote:
> Michal Sojka <sojkam1@fel.cvut.cz> writes:
> > +test_expect_success 'setup submodule' '
> > + rm -rf * .*
>
> Yikes. Please don't do this.
>
> [...]
>
> but it would be preferable to be even more explicit "rm -fr ?* .git".
Fixed. I did it like you suggested.
> Also make sure you don't break the chain of "&&" unnecessarily.
>
Fixed.
I've also split each my test into two separate tests. In the first one I
perform the rewrite and in the second I test that the result is what was
expected. I did it because the other tests in this file are structured the
same way.
Cheers,
Michal
next prev parent reply other threads:[~2010-01-29 15:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-25 13:06 filter-branch fix and tests Michal Sojka
2010-01-25 13:06 ` [PATCH 1/2] filter-branch: Fix to allow replacing submodules with another content Michal Sojka
2010-01-25 13:06 ` [PATCH 2/2] filter-branch: Add tests for submodules Michal Sojka
[not found] ` <alpine.DEB.1.00.1001261939420.4641@intel-tinevez-2-302>
2010-01-27 15:49 ` [PATCH] filter-branch fix and tests Michal Sojka
2010-01-27 16:18 ` Johannes Sixt
2010-01-27 23:41 ` Michal Sojka
2010-01-27 23:55 ` [PATCHv3] filter-branch: Add tests for submodules Michal Sojka
2010-01-28 0:14 ` Junio C Hamano
2010-01-28 9:02 ` Michal Sojka
2010-01-28 9:08 ` [PATCHv4 1/2] filter-branch: Fix to allow replacing submodules with another content Michal Sojka
2010-01-28 9:08 ` [PATCHv4 2/2] filter-branch: Add tests for submodules in tree-filter Michal Sojka
2010-01-28 21:57 ` Junio C Hamano
2010-01-29 15:20 ` Michal Sojka [this message]
2010-01-29 15:27 ` [PATCHv5 1/2] filter-branch: Fix to allow replacing submodules with another content Michal Sojka
2010-01-29 15:27 ` [PATCHv5 2/2] filter-branch: Add tests for submodules in tree-filter Michal Sojka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001291620.35269.sojkam1@fel.cvut.cz \
--to=sojkam1@fel.cvut.cz \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).