From: Todd Zullinger <tmz@pobox.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Johan Herland <johan@herland.net>,
Sverre Rabbelier <srabbelier@gmail.com>
Subject: Re: [RFH] rpm packaging failure
Date: Sat, 30 Jan 2010 23:12:36 -0500 [thread overview]
Message-ID: <20100131041236.GP29188@inocybe.localdomain> (raw)
In-Reply-To: <7vd40rjks4.fsf@alter.siamese.dyndns.org>
[-- Attachment #1: Type: text/plain, Size: 1614 bytes --]
Junio C Hamano wrote:
> To allow us to go forward a bit easier, I am planning to use the
> attached, as we would need some parts of it when we do start
> generating a separate package, I think.
Sounds good. One minor nit, below... ;)
> %define path_settings ETC_GITCONFIG=/etc/gitconfig prefix=%{_prefix} mandir=%{_mandir} htmldir=%{_docdir}/%{name}-%{version}
> +%{!?python_sitelib: %define python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")}
It is probably better to use %global rather than %define here. The
Fedora packaging guidelines now recommend this:
http://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define
The rationale is that %define only really lasts until the closing
brace, while %global persists. A bug in rpm has masked this for a
long time, but it now fixed in upstream rpm, which is packaged for
Fedora's rawhide and possible other rpm-based distros. A bit more
detail is available at:
https://www.redhat.com/archives/fedora-devel-list/2010-January/msg00093.html
(Which is linked, with an incorrect trailing '|' character from the
Fedora guidelines URL above.)
Using %global should work on older rpm versions as well as current
versions, so there should be no downside to using s/%define/%global in
most cases.
--
Todd OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
The secret to success is knowing who to blame for your failures.
-- Demotivators (www.despair.com)
[-- Attachment #2: Type: application/pgp-signature, Size: 542 bytes --]
next prev parent reply other threads:[~2010-01-31 4:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-30 9:24 [RFH] rpm packaging failure Junio C Hamano
2010-01-30 15:19 ` Todd Zullinger
2010-01-30 17:10 ` Junio C Hamano
2010-01-30 19:47 ` Todd Zullinger
2010-01-30 22:22 ` Junio C Hamano
2010-01-31 4:12 ` Todd Zullinger [this message]
2010-01-31 19:18 ` Junio C Hamano
2010-01-31 23:14 ` David Aguilar
2010-01-31 23:46 ` David Aguilar
2010-01-31 0:06 ` Johan Herland
2010-01-31 0:56 ` Sverre Rabbelier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100131041236.GP29188@inocybe.localdomain \
--to=tmz@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johan@herland.net \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox