git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: Nicolas Pitre <nico@fluxnic.net>,
	Sergio <sergio.callegari@gmail.com>,
	git@vger.kernel.org
Subject: Re: pack.packSizeLimit, safety checks
Date: Mon, 1 Feb 2010 08:28:16 -0800	[thread overview]
Message-ID: <20100201162816.GA9394@spearce.org> (raw)
In-Reply-To: <4B6700CF.1090106@viscovery.net>

Johannes Sixt <j.sixt@viscovery.net> wrote:
> Nicolas Pitre schrieb:
> > Grrrrr.  This is a terrible discrepency given that all the other 
> > arguments in Git are always byte based, with the optional k/m/g suffix, 
> > by using git_parse_ulong().  So IMHO I'd just change --max-pack-size to 
> > be in line with all the rest and have it accept bytes instead of MB.  
> > And of course I'd push such a change to be included in v1.7.0 along with 
> > the other incompatible fixes.
> 
> While at it, also change --big-file-threshold that fast-import learnt the
> other day...

Yup.  WTF was I thinking when I did megabytes as the default unit
on the command line...

-- 
Shawn.

  reply	other threads:[~2010-02-01 16:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-01  9:20 pack.packSizeLimit, safety checks Sergio
2010-02-01 16:11 ` Nicolas Pitre
2010-02-01 16:26   ` Johannes Sixt
2010-02-01 16:28     ` Shawn O. Pearce [this message]
2010-02-01 17:20       ` Junio C Hamano
2010-02-01 17:19   ` Junio C Hamano
2010-02-01 18:04     ` Nicolas Pitre
2010-02-01 18:45       ` Junio C Hamano
2010-02-04  2:14       ` Junio C Hamano
2010-02-04  2:31         ` Nicolas Pitre
2010-02-04  2:34           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100201162816.GA9394@spearce.org \
    --to=spearce@spearce.org \
    --cc=git@vger.kernel.org \
    --cc=j.sixt@viscovery.net \
    --cc=nico@fluxnic.net \
    --cc=sergio.callegari@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).