git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Teemu Matilainen <teemu.matilainen@iki.fi>
To: git discussion list <git@vger.kernel.org>
Cc: Sitaram Chamarty <sitaramc@gmail.com>
Subject: Re: [gitolite] repo config for delegated projects
Date: Thu, 4 Feb 2010 00:47:34 +0200	[thread overview]
Message-ID: <20100203224734.GI4808@reaktor.fi> (raw)
In-Reply-To: <20100203202249.GA27125@lapse.rw.madduck.net>

On Thu, 04 Feb 2010, martin f krafft wrote:

> src/gl-compile-conf:261 prohibits delegated repositories to make use
> of the functionality to configure config variables of the
> repositories:
> 
>   die "$WARN $fragment attempting to set repo configuration\n"
>     if $fragment ne 'master';
> 
> This is a bit unfortunate and makes me reconsider the use of
> delegations.
> 
> What is the reason for this restriction?

Well, the main reason probably is that I don't personally use delegation
and got tired of even thinking about the security concerns. =)

> Are there settings that are potentially compromising?

I think it depends on the setup and especially hooks.
Can't come up with any real problem, though.

> Would it be worth to consider making it configurable (e.g.
> ~/.gitolite.rc) whether to allow delegated repos to set config
> variables?

That's Sitaram's call. :)


-- 
	- Teemu

  reply	other threads:[~2010-02-03 22:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20100203035718.GA30644@lapse.rw.madduck.net>
     [not found] ` <2e24e5b91002022222h5ca3ebe6k75854a9a056f0ed1@mail.gmail.com>
2010-02-03 20:22   ` [gitolite] repo config for delegated projects martin f krafft
2010-02-03 22:47     ` Teemu Matilainen [this message]
2010-02-04  1:18     ` Sitaram Chamarty
2010-02-04  4:08       ` martin f krafft
2010-02-06  0:50         ` Sitaram Chamarty
2010-02-06  4:22           ` martin f krafft
2010-02-06  6:45             ` Sitaram Chamarty
2010-02-06 18:21           ` Teemu Matilainen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100203224734.GI4808@reaktor.fi \
    --to=teemu.matilainen@iki.fi \
    --cc=git@vger.kernel.org \
    --cc=sitaramc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).