From: "Shawn O. Pearce" <spearce@spearce.org>
To: Nicolas Pitre <nico@fluxnic.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 3/3] make --max-pack-size argument to 'git pack-object' count in bytes
Date: Wed, 3 Feb 2010 20:00:46 -0800 [thread overview]
Message-ID: <20100204040046.GR14799@spearce.org> (raw)
In-Reply-To: <1265255308-20514-3-git-send-email-nico@fluxnic.net>
Nicolas Pitre <nico@fluxnic.net> wrote:
> The value passed to --max-pack-size used to count in MiB which was
> inconsistent with the corresponding configuration variable as well as
> other command arguments which are defined to count in bytes with an
> optional unit suffix. This brings --max-pack-size in line with the
> rest of Git.
...
> Documentation/RelNotes-1.7.0.txt | 8 +++++++-
> Documentation/config.txt | 11 +++++++----
> Documentation/git-pack-objects.txt | 5 +++--
> Documentation/git-repack.txt | 8 +++++---
> builtin-pack-objects.c | 11 ++++++-----
> t/t5300-pack-object.sh | 14 ++++++++------
> 6 files changed, 36 insertions(+), 21 deletions(-)
Shouldn't we also change fast-import.c ?
--
Shawn.
next prev parent reply other threads:[~2010-02-04 4:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-04 3:48 [PATCH 1/3] fix multiple issues with t5300 Nicolas Pitre
2010-02-04 3:48 ` [PATCH 2/3] pack-objects: fix pack generation when using pack_size_limit Nicolas Pitre
2010-02-04 3:48 ` [PATCH 3/3] make --max-pack-size argument to 'git pack-object' count in bytes Nicolas Pitre
2010-02-04 4:00 ` Shawn O. Pearce [this message]
2010-02-04 4:38 ` Junio C Hamano
2010-02-04 17:11 ` Junio C Hamano
2010-02-04 17:24 ` Shawn O. Pearce
2010-02-04 17:58 ` Nicolas Pitre
2010-02-04 17:59 ` Shawn O. Pearce
2010-02-04 19:10 ` [PATCH] fast-import: count --max-pack-size " Junio C Hamano
2010-02-04 19:13 ` Shawn O. Pearce
2010-02-04 20:03 ` Ilari Liusvaara
2010-02-04 17:49 ` [PATCH 3/3] make --max-pack-size argument to 'git pack-object' count " Nicolas Pitre
2010-02-04 18:00 ` Shawn O. Pearce
2010-02-04 18:11 ` Nicolas Pitre
2010-02-04 21:20 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100204040046.GR14799@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nico@fluxnic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).