git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: git@vger.kernel.org, 568470-forwarded@bugs.debian.org
Cc: Matthijs Kooijman <matthijs@stdin.nl>, Paul Mackerras <paulus@samba.org>
Subject: gitk: not all colours are configurable (so grey on black scheme is not possible)
Date: Thu, 4 Feb 2010 17:32:42 -0600	[thread overview]
Message-ID: <20100204233242.GA5441@progeny.tock> (raw)

Hi gitsters,

The following request was submitted against the Debian gitk package.
Sounds sensible to me; anyone interested?

From: Matthijs Kooijman <matthijs@stdin.nl>
Package: gitk
Version: 1:1.6.6-1
Severity: wishlist

gitk allows configuration of the colours used in the interface, by using
the edit -> preferences dialogs. I've used this feature to set the
background colour to black and the foreground colour to grey. However,
some colours in the interface are not configurable, which makes this
scheme very uncomfortable to work with.

In particular, I'm having the following issues:
 * The foreground text color of the interface. The setting "interface
   colour" allows me to set the background of most interface parts.
   (except for the areas in the interface showing the list, diff, etc.
   which are controllable with the "background colour" setting).
   However, I can't set the "interface colour" to a dark tone, since I
   can't control the text.

   This should be solved by adding an "interface text colour" setting.
 * The background text of some of the interface elements (in particular
   some textboxes in the new view / edit view dialogs) are controlled by
   the "background colour" setting instead of the "interface colour".
   However, the text color is not controlled by the "foregrond colour"
   (and, as noted in the previous point, is not configurable anywhere),
   so I get unreadable text if I set "background colour" to black.

   This should be solved by making all text boxes listen to the
   "interface colour" setting, or by making the text in these text boxes
   listen to the "foreground colour" setting.
 * In the diff view, the two header lines of every file (containing the
   filename and git hashes) has a fixed grey background. The text
   colour, however, is controlled by the "foreground colour" setting, so
   setting that to grey leaves you with unreadable headers.
   
   This should be solved by making a "Diff headers background colour"
   setting, or something similar.

Gr.

Matthijs
-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32.7 (PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages gitk depends on:
ii  git-core                      1:1.6.6-1  fast, scalable, distributed revisi
ii  tk                            8.4.16-2   The Tk toolkit for Tcl and X11 (de

                 reply	other threads:[~2010-02-04 23:33 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100204233242.GA5441@progeny.tock \
    --to=jrnieder@gmail.com \
    --cc=568470-forwarded@bugs.debian.org \
    --cc=git@vger.kernel.org \
    --cc=matthijs@stdin.nl \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).