From mboxrd@z Thu Jan 1 00:00:00 1970 From: Larry D'Anna Subject: Re: [PATCH v3 2/3] git-push: clean up some of the output from git push --porcelain Date: Tue, 9 Feb 2010 11:21:24 -0500 Message-ID: <20100209162124.GA27790@cthulhu> References: <214a0317f2e4707a866b2f5d10509296bc1479c1.1265661033.git.larry@elder-gods.org> <7vtytrih7b.fsf@alter.siamese.dyndns.org> <7vvde7h1mn.fsf@alter.siamese.dyndns.org> <20100208213256.GA470@coredump.intra.peff.net> <7viqa7cqs9.fsf@alter.siamese.dyndns.org> <20100208223107.GB21718@cthulhu> <7vpr4f9wey.fsf@alter.siamese.dyndns.org> <20100209045417.GA15210@cthulhu> <7v4olqlva7.fsf@alter.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jeff King , git@vger.kernel.org, "Shawn O. Pearce" To: Junio C Hamano X-From: git-owner@vger.kernel.org Tue Feb 09 17:21:37 2010 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NesqA-0000HB-La for gcvg-git-2@lo.gmane.org; Tue, 09 Feb 2010 17:21:31 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754879Ab0BIQV0 (ORCPT ); Tue, 9 Feb 2010 11:21:26 -0500 Received: from cthulhu.elder-gods.org ([140.239.99.253]:38696 "EHLO cthulhu.elder-gods.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754761Ab0BIQVZ (ORCPT ); Tue, 9 Feb 2010 11:21:25 -0500 Received: by cthulhu.elder-gods.org (Postfix, from userid 1000) id 659C382200E; Tue, 9 Feb 2010 11:21:24 -0500 (EST) Content-Disposition: inline In-Reply-To: <7v4olqlva7.fsf@alter.siamese.dyndns.org> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: * Junio C Hamano (gitster@pobox.com) [100209 02:31]: > Larry D'Anna writes: > > > * Junio C Hamano (gitster@pobox.com) [100208 17:48]: > >> *1* As I hinted repeatedly, I think many of them are mere churn, except > >> for "don't advice porcelain scripts" (good) and perhaps "exit with failure > >> status upon only this kind of failure" (I am undecided). > > > > What about the "To" lines? It seems that they really should go to stdout (if > > --porcelain is selected). Otherwise, how does the reader of stdout know which > > refs got pushed to which remote? > > I think that probably is an improvement. > > We would probably need documentation updates to cover the parsing of "To", > at least; it might be cleaner to have a separate section for porcelain > writers. And tests. But this series won't hit next until 1.7.0 ships so > we have enough time to polish the details. > > I queued the series and once merged it to 'pu' but seeing some tests fail, > I reverted the merge. The error is somewhat curious... I bisected, and this was introduced by 6d525d3 receive-pack: Send hook output over side band #2 --larry