From: Larry D'Anna <larry@elder-gods.org>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 6/6] receive-pack: Send hook output over side band #2
Date: Tue, 9 Feb 2010 12:33:07 -0500 [thread overview]
Message-ID: <20100209173307.GA1115@cthulhu> (raw)
In-Reply-To: <20100209172027.GC26964@spearce.org>
* Shawn O. Pearce (spearce@spearce.org) [100209 12:20]:
> Larry D'Anna <larry@elder-gods.org> wrote:
> >
> > This breaks t5401. See <7v4olqlva7.fsf@alter.siamese.dyndns.org> in another thread.
>
> No. Your patch causes t5401 to break. If you apply this series on
> top of maint, its fine. If you merge this series into master, and
> correctly fix the Win32 merge conflict in run-command.c, its fine.
Well, the version of this commit that's in pu is defiantly failing t5401 on my
machine. Just tested it again with a clean build. My series isn't an ancestor
of it either. Did you notice the failure is intermittent? You have to run it a
few times before it fails.
--larry
next prev parent reply other threads:[~2010-02-09 17:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-05 20:57 [PATCH v2 0/6] receive-pack hooks over sideband Shawn O. Pearce
2010-02-05 20:57 ` [PATCH v2 1/6] run-command: Allow stderr to be a caller supplied pipe Shawn O. Pearce
2010-02-05 20:57 ` [PATCH v2 2/6] run-command: support custom fd-set in async Shawn O. Pearce
2010-02-05 20:57 ` [PATCH v2 3/6] send-pack: demultiplex a sideband stream with status data Shawn O. Pearce
2010-02-05 20:57 ` [PATCH v2 4/6] receive-pack: Refactor how capabilities are shown to the client Shawn O. Pearce
2010-02-05 20:57 ` [PATCH v2 5/6] receive-pack: Wrap status reports inside side-band-64k Shawn O. Pearce
2010-02-05 21:14 ` Junio C Hamano
2010-02-05 21:53 ` Shawn O. Pearce
2010-02-05 22:19 ` Junio C Hamano
2010-02-05 20:57 ` [PATCH v2 6/6] receive-pack: Send hook output over side band #2 Shawn O. Pearce
2010-02-09 16:52 ` Larry D'Anna
2010-02-09 17:20 ` Shawn O. Pearce
2010-02-09 17:33 ` Larry D'Anna [this message]
2010-02-09 17:41 ` Larry D'Anna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100209173307.GA1115@cthulhu \
--to=larry@elder-gods.org \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).