From: Johannes Sixt <j6t@kdbg.org>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org,
"João Carlos Mendes Luís" <jonny@jonny.eng.br>,
"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH 1/4] make_absolute_path(): Do not append redundant slash
Date: Tue, 9 Feb 2010 20:10:43 +0100 [thread overview]
Message-ID: <201002092010.43910.j6t@kdbg.org> (raw)
In-Reply-To: <1265734950-15145-1-git-send-email-pclouds@gmail.com>
On Dienstag, 9. Februar 2010, Nguyễn Thái Ngọc Duy wrote:
> @@ -54,8 +54,9 @@ const char *make_absolute_path(const char *path)
> if (len + strlen(last_elem) + 2 > PATH_MAX)
> die ("Too long path name: '%s/%s'",
> buf, last_elem);
> - buf[len] = '/';
> - strcpy(buf + len + 1, last_elem);
> + if (*buf != '/' || buf[1] != '\0')
> + buf[len++] = '/';
Huh? You are adding a slash unless buf is exactly "/". That is, when buf
is "/foo/" you still add a slash? That's not exactly avoiding redundancy.
(Disclaimer: I didn't analyze the rest of the function whether my claim is
true.)
> + strcpy(buf + len, last_elem);
> free(last_elem);
> last_elem = NULL;
> }
-- Hannes
next prev parent reply other threads:[~2010-02-09 19:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-09 17:02 [PATCH 1/4] make_absolute_path(): Do not append redundant slash Nguyễn Thái Ngọc Duy
2010-02-09 17:02 ` [PATCH 2/4] rev-parse: make --git-dir return /.git instead of //.git Nguyễn Thái Ngọc Duy
2010-02-09 19:18 ` Johannes Sixt
2010-02-11 10:07 ` Nguyen Thai Ngoc Duy
2010-02-09 17:02 ` [PATCH 3/4] Support working directory located at root Nguyễn Thái Ngọc Duy
2010-02-09 19:19 ` Johannes Sixt
2010-02-11 12:44 ` Nguyen Thai Ngoc Duy
2010-02-09 17:02 ` [PATCH 4/4] Add test for using Git at root of file system Nguyễn Thái Ngọc Duy
2010-02-10 13:10 ` João Carlos Mendes Luís
2010-02-11 10:01 ` Nguyen Thai Ngoc Duy
2010-02-09 19:10 ` Johannes Sixt [this message]
2010-02-11 10:00 ` [PATCH 1/4] make_absolute_path(): Do not append redundant slash Nguyen Thai Ngoc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201002092010.43910.j6t@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonny@jonny.eng.br \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).