From: "SZEDER Gábor" <szeder@fzi.de>
To: Stephen Boyd <bebarino@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Jay Soffian <jaysoffian@gmail.com>
Subject: Re: [PATCH] blame: allow -L n,m to have an m bigger than the file's line count
Date: Wed, 10 Feb 2010 13:42:38 +0100 [thread overview]
Message-ID: <20100210124238.GA31978@neumann> (raw)
In-Reply-To: <1265786864-5460-1-git-send-email-bebarino@gmail.com>
Hi Stephen,
On Tue, Feb 09, 2010 at 11:27:44PM -0800, Stephen Boyd wrote:
> Sometimes I want to blame a file starting at some point and ending at
> the end of the file. In my haste I'll write something like this:
>
> $ git blame -L5,2342343 -- builtin-blame.c
>
> and be greeted by a die message telling me that my end range is greater
> than the number of lines in the file. Obviously I can do:
>
> $ git blame -L5, -- builtin-blame.c
>
> and get what I want but that isn't very discoverable. If the range is
> greater than the number of lines just truncate the range to go up to
> the end of the file.
>
> Update the docs to more accurately reflect the defaults for n and m too.
>
> Signed-off-by: Stephen Boyd <bebarino@gmail.com>
> ---
>
> I realize this is late in the game for 1.7.0 so I'll resend if this
> isn't picked up.
>
> Documentation/blame-options.txt | 4 +++-
> builtin-blame.c | 4 +++-
> t/t8003-blame.sh | 4 ++--
> 3 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/blame-options.txt b/Documentation/blame-options.txt
> index 4833cac..620660d 100644
> --- a/Documentation/blame-options.txt
> +++ b/Documentation/blame-options.txt
> @@ -9,7 +9,7 @@
> --show-stats::
> Include additional statistics at the end of blame output.
>
> --L <start>,<end>::
> +-L [<start>],[<end>]::
> Annotate only the given line range. <start> and <end> can take
> one of these forms:
>
> @@ -31,6 +31,8 @@ starting at the line given by <start>.
> This is only valid for <end> and will specify a number
> of lines before or after the line given by <start>.
> +
> +Note: if <start> is not given it defaults to 1 and if <end> is not given it
> +defaults to the number of lines in the file.
>
> -l::
> Show long rev (Default: off).
I agree that its too late for the behavioral change, but IMHO the
documentation update part can be considered as a bugfix, and as such
it could perhaps be included in 1.7.0. (I never knew that <start> or
<end> can be omitted... so thanks for the hint anyway)
Best,
Gábor
next prev parent reply other threads:[~2010-02-10 12:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-10 7:27 [PATCH] blame: allow -L n,m to have an m bigger than the file's line count Stephen Boyd
2010-02-10 12:42 ` SZEDER Gábor [this message]
2010-02-10 13:37 ` Jay Soffian
2010-02-10 16:25 ` Stephen Boyd
2010-02-10 18:58 ` Junio C Hamano
2010-02-10 19:39 ` Jay Soffian
2010-02-10 19:47 ` Junio C Hamano
2010-02-10 19:51 ` Jay Soffian
2010-02-12 0:25 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100210124238.GA31978@neumann \
--to=szeder@fzi.de \
--cc=bebarino@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jaysoffian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).