From: "Stefan-W. Hahn" <stefan.hahn@s-hahn.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/4] git-mailsplit: add `mailsplit.keepcr` configuration variable.
Date: Fri, 12 Feb 2010 22:03:36 +0100 [thread overview]
Message-ID: <20100212210336.GB32018@pille.home> (raw)
In-Reply-To: <7vhbpnqrxr.fsf@alter.siamese.dyndns.org>
Also sprach Junio C Hamano am Thu, 11 Feb 2010 at 15:21:52 -0800:
> > With this patch the behaviour of git-mailsplit can be set via
> > configuration file.
>
> This probably is a bad change. mailsplit is designed to be usable without
> being inside any git repository. With this change, doesn't the command
> start failing to run when run outside a git repository?
Ouch, I didn't mind this.
But perhaps it will be a better aproach to make such a configuration
available for git-am. I will make a patch for this soon.
Stefan
--
Stefan-W. Hahn It is easy to make things.
/ mailto:stefan.hahn@s-hahn.de / It is hard to make things simple.
Please note that according to the German law on data retention,
information on every electronic information exchange with me is
retained for a period of six months.
Bundesgesetzblatt:
http://www.bgblportal.de/BGBL/bgbl1f/bgbl107s3198.pdf
next prev parent reply other threads:[~2010-02-12 21:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-11 21:26 [PATCHv2 0/4] Using git-mailsplit in mixed line ending environment Stefan-W. Hahn
2010-02-11 21:26 ` [PATCH 1/4] git-mailsplit: Show parameter '--keep-cr' in usage and documentation Stefan-W. Hahn
2010-02-11 21:26 ` [PATCH 2/4] git-mailsplit: add `mailsplit.keepcr` configuration variable Stefan-W. Hahn
2010-02-11 23:21 ` Junio C Hamano
2010-02-12 21:03 ` Stefan-W. Hahn [this message]
2010-02-12 21:49 ` Junio C Hamano
2010-02-12 22:00 ` Junio C Hamano
2010-02-12 22:04 ` Stefan-W. Hahn
2010-02-11 21:26 ` [PATCH 3/4] git-am: Add command line parameter `--keep-cr` passing it to git-mailsplit Stefan-W. Hahn
2010-02-11 23:21 ` Junio C Hamano
2010-02-12 21:05 ` Stefan-W. Hahn
2010-02-12 21:54 ` Junio C Hamano
2010-02-11 21:26 ` [PATCH 4/4] Adding test for `--keep-cr` for git-mailsplit and git-am Stefan-W. Hahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100212210336.GB32018@pille.home \
--to=stefan.hahn@s-hahn.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).