From: Jeff King <peff@peff.net>
To: "Björn Gustavsson" <bgustavsson@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] add -p: make the beginning of the hunk easier to see
Date: Sat, 13 Feb 2010 06:55:12 -0500 [thread overview]
Message-ID: <20100213115512.GA5472@coredump.intra.peff.net> (raw)
In-Reply-To: <6672d0161002130342h348765a0j76f63972c4bbe060@mail.gmail.com>
On Sat, Feb 13, 2010 at 12:42:56PM +0100, Björn Gustavsson wrote:
> As an alternative to my patch, the color coding could be changed.
> The beginning of a chunk is now marked with a faint bluish color (the part
> that looks like "@@ -42,9 +43,8 @@").
You can tweak that color with the color.diff.frag config variable.
> Giving the "Stage this hunk..." prompt some noticeable color (such as red),
> could make it easier to the see beginning of the hunk. Or
> simply doing a form-feed (but I suppose not everyone would
> like that).
If you are using color.interactive (or color.ui), that should already be
"bold blue". You can change it to red with color.interactive.prompt.
Personally, I prefer the color approach. It's less ugly looking (IMHO),
and it is configurable, so people who don't like it don't have to see
it. It's also already implemented, though one could perhaps make an
argument for changing the defaults.
-Peff
next prev parent reply other threads:[~2010-02-13 11:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-13 11:07 [PATCH] add -p: make the beginning of the hunk easier to see Björn Gustavsson
2010-02-13 11:23 ` Jeff King
2010-02-13 11:25 ` Jeff King
2010-02-13 11:36 ` Björn Gustavsson
2010-02-13 11:33 ` Björn Gustavsson
2010-02-13 11:42 ` Björn Gustavsson
2010-02-13 11:55 ` Jeff King [this message]
2010-02-13 14:34 ` Björn Gustavsson
2010-02-13 15:04 ` Julian Phillips
2010-02-13 16:01 ` Björn Gustavsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100213115512.GA5472@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=bgustavsson@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).