From: Jonathan Nieder <jrnieder@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Mark Lodato <lodatom@gmail.com>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Add an optional argument for --color options
Date: Sun, 14 Feb 2010 06:21:18 -0600 [thread overview]
Message-ID: <20100214122118.GA3630@progeny.tock> (raw)
In-Reply-To: <20100214064408.GB20630@coredump.intra.peff.net>
Jeff King wrote:
> On Sat, Feb 13, 2010 at 05:01:15PM -0500, Mark Lodato wrote:
>> Make git-branch, git-show-branch, git-grep, and all the diff-based
>> programs accept an optional argument <when> for --color.
[...]
> My only complaint in that respect is that there are no tests. However,
> I'm not sure we can get a very satisfying test, since the test scripts
> may or may not have stdout going to a tty.
See [1]. ;-)
Hope that helps,
Jonathan
[1] http://thread.gmane.org/gmane.comp.version-control.git/139831/focus=139906
next prev parent reply other threads:[~2010-02-14 12:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-13 22:01 [PATCH] Add an optional argument for --color options Mark Lodato
2010-02-14 6:44 ` Jeff King
2010-02-14 12:21 ` Jonathan Nieder [this message]
2010-02-14 14:58 ` Mark Lodato
2010-02-15 1:18 ` Jonathan Nieder
2010-02-15 5:23 ` Jeff King
2010-02-15 1:23 ` Usage messages produced by parseopt (Re: [PATCH] Add an optional argument for --color options) Jonathan Nieder
2010-02-15 5:21 ` [PATCH] Add an optional argument for --color options Jeff King
2010-02-15 6:02 ` Junio C Hamano
2010-02-14 11:39 ` Junio C Hamano
2010-02-14 14:46 ` Mark Lodato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100214122118.GA3630@progeny.tock \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=lodatom@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).