From: Jeff King <peff@peff.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Sebastian Celis <sebastian@sebastiancelis.com>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: [PATCH v3 5/6] am: Fix launching of pager
Date: Sun, 14 Feb 2010 23:42:24 -0500 [thread overview]
Message-ID: <20100215044223.GA3336@coredump.intra.peff.net> (raw)
In-Reply-To: <20100215032533.GA19230@progeny.tock>
On Sun, Feb 14, 2010 at 09:25:33PM -0600, Jonathan Nieder wrote:
> --- a/git-sh-setup.sh
> +++ b/git-sh-setup.sh
> @@ -107,6 +107,25 @@ git_editor() {
> eval "$GIT_EDITOR" '"$@"'
> }
>
> +git_pager() {
> + if test -z "${GIT_PAGER+set}"
> + then
> + if tty <&1 >/dev/null 2>/dev/null
We seem to use "test -t 1" for this elsewhere, and I don't see us using
"tty" anywhere else. It is POSIX, and I tested that even Solaris 8 and
AIX 6.1 have it. So I don't think it is a portability issue, but others
may know more than I.
-Peff
next prev parent reply other threads:[~2010-02-15 4:42 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-13 21:14 'git svn log' no longer uses the pager Sebastian Celis
2010-02-13 23:51 ` Jeff King
2010-02-14 11:54 ` Jonathan Nieder
2010-02-14 11:55 ` [PATCH 1/6] Fix 'git var' usage synopsis Jonathan Nieder
2010-02-15 2:22 ` Junio C Hamano
2010-02-15 2:36 ` [PATCH v2 " Jonathan Nieder
2010-02-15 4:47 ` Jeff King
2010-02-14 11:59 ` [PATCH 2/6] Make 'git var GIT_PAGER' always print the configured pager Jonathan Nieder
2010-02-15 5:00 ` Jeff King
2010-02-15 5:44 ` Jonathan Nieder
2010-02-15 7:57 ` Jeff King
2010-02-14 12:02 ` [PATCH 3/6] git.1: Clarify the behavior of the --paginate option Jonathan Nieder
2010-02-15 4:55 ` Jeff King
2010-02-14 12:06 ` [PATCH 4/6] git svn: Fix launching of pager Jonathan Nieder
2010-02-15 7:58 ` Eric Wong
2010-02-14 12:07 ` [PATCH 5/6] am: " Jonathan Nieder
2010-02-15 2:30 ` Junio C Hamano
2010-02-15 2:59 ` [PATCH v2 " Jonathan Nieder
2010-02-15 3:25 ` [PATCH v3 " Jonathan Nieder
2010-02-15 4:42 ` Jeff King [this message]
2010-02-15 5:04 ` [PATCH v4 " Jonathan Nieder
2010-02-15 5:12 ` Jeff King
2010-02-15 20:26 ` Johannes Sixt
2010-02-14 12:13 ` [PATCH 6/6] tests: Add tests for automatic use " Jonathan Nieder
2010-02-15 5:10 ` Jeff King
2010-02-15 5:35 ` [PATCH v2 " Jonathan Nieder
2010-02-15 5:37 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100215044223.GA3336@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=sebastian@sebastiancelis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).