From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Gabriel Filion <lelutin@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] require_work_tree broken with NONGIT_OK
Date: Mon, 15 Feb 2010 02:49:22 -0500 [thread overview]
Message-ID: <20100215074922.GA5549@coredump.intra.peff.net> (raw)
In-Reply-To: <7vzl3bj95l.fsf@alter.siamese.dyndns.org>
On Sun, Feb 14, 2010 at 10:38:30PM -0800, Junio C Hamano wrote:
> > + test git rev-parse --is-inside-work-tree >/dev/null 2>&1 ||
>
> I don't think this would ever work with "test" at the beginning.
Oops. I totally missed that when reviewing the patch. :-/
Thinking on this a bit more, I think Gabriel's script is a little
broken. It sets NONGIT_OK to not have a git repository, but then it
requires a working tree, which doesn't make any sense.
That being said, I think it is still a good change, as the correct error
message is better than the shell barfing.
-Peff
next prev parent reply other threads:[~2010-02-15 7:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-15 3:51 [PATCH] require_work_tree broken with NONGIT_OK Gabriel Filion
2010-02-15 5:34 ` Jeff King
2010-02-15 6:38 ` Junio C Hamano
2010-02-15 7:24 ` Gabriel Filion
2010-02-15 7:49 ` Jeff King [this message]
2010-02-15 15:14 ` Gabriel Filion
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100215074922.GA5549@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=lelutin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).